Last modified: 2011-04-28 15:06:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T25027, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 23027 - Abuse filter does not allow for use of old_text or old_html
Abuse filter does not allow for use of old_text or old_html
Status: RESOLVED DUPLICATE of bug 22075
Product: MediaWiki extensions
Classification: Unclassified
AbuseFilter (Other open bugs)
unspecified
All All
: Low minor with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-04-02 11:26 UTC by Matthew P. Del Buono
Modified: 2011-04-28 15:06 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew P. Del Buono 2010-04-02 11:26:06 UTC
In the details of the abuse filter log -- such as http://test.wikipedia.org/w/index.php?title=Special:AbuseLog&details=1784 -- one can clearly see the presence of the old_text and old_html variables. These variables are clearly documented at http://www.mediawiki.org/wiki/Extension:AbuseFilter/RulesFormat

However attempting to use these variables in a filter results in a syntax error for unknown variables:

"abc" in old_text

results in

Syntax error detected: Unrecognised variable old_text at character 8

new_text and new_html work fine.

This is a problem because to use new_text or new_html, a proper filter often needs to also check old_text or old_html, respectively. Enwiki in particular is dealing with a particular vandal against whom new_text is the only appropriate choice, but without old_text this filter is encountering false positives. 

Looking at the source code, old_text and old_html already appear to be implemented, it just seems that old_text and old_html are just not recognized by the abuse filter parser for some reason.
Comment 1 Andrew Garrett 2010-04-02 11:42:21 UTC
They are deliberately disabled for performance reasons. Some engineering would be required to bring them to a state where they would not bring the site down.
Comment 2 MZMcBride 2010-07-17 21:14:06 UTC
Can you elaborate? I don't understand how retrieving the static HTML would be problematic.
Comment 3 Andrew Garrett 2010-07-24 03:08:43 UTC
It requires reparsing the old text, which in some cases can take tens of seconds. Of course, the old text has already been parsed at some point, but some engineering is needed to actually retrieve this parsed HTML from the appropriate cache.
Comment 4 John Mark Vandenberg 2011-04-28 08:07:33 UTC
old_wikitext is available.  Is there is use case for old_html or old_text ?
Comment 5 John Mark Vandenberg 2011-04-28 09:37:53 UTC

*** This bug has been marked as a duplicate of bug 24310 ***
Comment 6 MZMcBride 2011-04-28 15:06:21 UTC

*** This bug has been marked as a duplicate of bug 22075 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links