Last modified: 2013-01-06 11:59:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24981, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 22981 - Sighted index pages lack quality indicators from the ProofreadPage extension due to LinkHolderArray bug
Sighted index pages lack quality indicators from the ProofreadPage extension ...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
unspecified
All All
: Normal normal with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
https://secure.wikimedia.org/wikisour...
: patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-03-27 23:15 UTC by Beau
Modified: 2013-01-06 11:59 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch fixing the problem in the LinkHolderArray class (1.23 KB, patch)
2010-05-02 21:54 UTC, Beau
Details

Description Beau 2010-03-27 23:15:50 UTC
The extension FlaggedRevs has been recently deployed on pl.wikisource.

Sighted index pages show no quality indicators from the Proofread Page extension. After reviewing an index page and purging it, quality indicators disappear. The only way to get them back is to remove the sighted flag.
Comment 1 Beau 2010-05-02 21:54:07 UTC
Created attachment 7347 [details]
Patch fixing the problem in the LinkHolderArray class

The current implementation of a LinkHolderArray ommits cached links in the call of the hook GetLinkColours.

This problem can be observed when a page is parsed multiple times. At the first time, everything is ok, because the linkCache is empty. After that the hook GetLinkColours is never called, because all links are cached ( $query is empty ).
Comment 2 ThomasV 2010-06-14 13:22:56 UTC
thanks for the patch. I commited it.
Comment 3 ThomasV 2010-06-14 13:26:37 UTC
btw, it was r67993

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links