Last modified: 2011-04-30 01:21:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24947, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 22947 - Bug Fix: getSkinName() doesn't work with $wgAllowUserSkin=false
Bug Fix: getSkinName() doesn't work with $wgAllowUserSkin=false
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.15.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-03-25 17:46 UTC by Gordon McKinney
Modified: 2011-04-30 01:21 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Unix Diff of Change (833 bytes, text/plain)
2010-03-25 17:46 UTC, Gordon McKinney 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Gordon McKinney 2010-03-25 17:46:43 UTC 
Created attachment 7242 [details]
Unix Diff of Change

getSkinName() doesn't work with $wgAllowUserSkin=false, bug fix attached
Comment 1 Alexandre Emsenhuber [IAlex] 2010-03-25 19:08:26 UTC 
The problem is that for SkinTemplate-based skins you need to call initPage() before getSkinName() so that the member "skinname" is set correctly, $wgAllowUserSkin won't change that.
Comment 2 Gordon McKinney 2010-03-25 19:24:46 UTC 
Sorry but my debug session with $wgAllowUserSkin set to true and false does in fact change this function's output. I wouldn't have posted this if I didn't have the problem.
Comment 3 Alexandre Emsenhuber [IAlex] 2010-11-13 11:04:30 UTC 
Marking this as FIXED; in 1.16 you can call this function when you want since the skinname member is set when creating the object.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links