Last modified: 2012-09-27 01:11:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24916, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 22916 - Styles specified in Vector stylesheet are overridden by Shared.css
Styles specified in Vector stylesheet are overridden by Shared.css
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-03-21 20:16 UTC by Lisa Ridley
Modified: 2012-09-27 01:11 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Lisa Ridley 2010-03-21 20:16:01 UTC 
The stylesheets for the vector skin are loading in the wrong order.  The common/shared.css stylesheet is loading after the vector/main-ltr.css stylesheet, effectively overriding any skin-specific styling.
Comment 1 Roan Kattouw 2010-03-22 20:41:52 UTC 
Does this bug happen for any of the other skins? (I mean the loading order, not necessarily issues arising from it.)
Comment 2 Lisa Ridley 2010-03-22 23:19:34 UTC 
No, I checked monobook and modern (I didn't check any of the others).  Those skins load the stylesheets in the correct order.

On Vector, the vector/main-ltr.css or -rtl.css stylesheet (whichever is applicable) is being loaded first, followed by shared.css and commonPrint.css, followed by the wiki stylesheets and the user stylesheets (if user css is enabled).  This causes any elements that have been redefined in the vector specific stylesheet to be overwritten by shared.css and commonPrint.css.

I'm not sure where the browser specific stylesheets are loading as I'm using Firefox and did not check IE.

Monobook and modern load the shared.css and commonPrint.css stylesheets, then load the skin-specific main.css stylesheet, followed by the remaining ones.

I have a fix (I think); I just haven't had time to post it as I've been working on a client project.

I should be able to post it either tonight or sometime tomorrow.
Comment 3 Lisa Ridley 2010-03-23 17:13:01 UTC 
fixed with 464080
Comment 4 Krinkle 2011-01-03 20:51:58 UTC 
r64080
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links