Last modified: 2013-06-18 15:53:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24874, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 22874 - ethnio notice cookie isn't remembered properly
ethnio notice cookie isn't remembered properly
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-03-18 02:00 UTC by Derk-Jan Hartman
Modified: 2013-06-18 15:53 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Derk-Jan Hartman 2010-03-18 02:00:20 UTC
The notice supposedly should only be shown once, but some people report to have already seen it 20 times. That means that there might be something wrong with the setting/reading of the cookie value.

http://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Do_I_live_near_San_Francisco.3F_No_I_bloody_well_don.27t.21

Lack of attention for issues as these, causes people to add CSS to ignore ALL sitenotices ALWAYS. As such I think that any sitenotice has great responsibility to not muck it up for the rest.
Comment 1 Casey Brown 2010-03-18 11:11:07 UTC
Doesn't the cookie only get set when you click on the banner?  (i.e. you open up the "sign up" form)
Comment 2 Roan Kattouw 2010-03-18 11:42:49 UTC
(In reply to comment #1)
> Doesn't the cookie only get set when you click on the banner?  (i.e. you open
> up the "sign up" form)

I think so, yes. However, adding a [dismiss] link that hides the banner and sets the cookie should be trivial.
Comment 3 Casey Brown 2010-03-18 19:18:44 UTC
(In reply to comment #2)
> I think so, yes. However, adding a [dismiss] link that hides the banner and
> sets the cookie should be trivial.

If that's the case, then the cookie *is* actually being remembered properly, it's just not clear how to hide the banner.  You're right though, adding a dismiss link shouldn't be a problem either.
Comment 4 Antoine "hashar" Musso (WMF) 2013-02-01 13:36:08 UTC
I am entirely sure this has been fixed over time.  During the last fundraiser I have hidden the banner and never received it again.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links