Last modified: 2014-08-28 15:24:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24847, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 22847 - If oi_archive_name = '' give error instead of linking to obviously invalid url
If oi_archive_name = '' give error instead of linking to obviously invalid url
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
unspecified
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
http://commons.wikimedia.org/wiki/Fil...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-03-16 12:31 UTC by Derk-Jan Hartman
Modified: 2014-08-28 15:24 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Derk-Jan Hartman 2010-03-16 12:31:47 UTC
Please see the URL. The oldest image thumb is missing. If you click it, you are taken to directory of the image thumbs. So you have the image history:

http://upload.wikimedia.org/wikipedia/commons/c/c1/Resilient_Barnstar.png. http://upload.wikimedia.org/wikipedia/commons/archive/c/c1/

instead of

http://upload.wikimedia.org/wikipedia/commons/1/13/Barnstar-camera.png
http://upload.wikimedia.org/wikipedia/commons/archive/1/13/20080106201537!Barnstar-camera.png

I'm not sure if this is intentional. Perhaps if the old image is indeed actually missing, it is better generate an understandable error ?
Comment 1 Sam Reed (reedy) 2011-07-08 23:51:57 UTC
http://commons.wikimedia.org/wiki/File:Resilient_Barnstar.png

It knows there is no thumbnail, and says as such

So the link should not be built to point at no file

-shell
Comment 2 Gerrit Notification Bot 2014-08-03 04:19:30 UTC
Change 151378 had a related patch set uploaded by Brian Wolff:
Making missing old files not try to render a thumbnail

https://gerrit.wikimedia.org/r/151378
Comment 3 Gerrit Notification Bot 2014-08-28 07:43:30 UTC
Change 151378 merged by jenkins-bot:
Making missing old files not try to render a thumbnail

https://gerrit.wikimedia.org/r/151378
Comment 4 Bawolff (Brian Wolff) 2014-08-28 15:24:39 UTC
Output changed for such a case. Once the above is deployed to commons, can you verify the new behaviour is what you want?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links