Last modified: 2011-01-25 00:11:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24822, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 22822 - Parsing the pagename parameter does not support pipe characters
Parsing the pagename parameter does not support pipe characters
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
SemanticForms (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Yaron Koren
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-03-13 11:43 UTC by Robert Michel
Modified: 2011-01-25 00:11 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Fix for SF_FormEdit.php special page to allow use of {{!}} (504 bytes, application/octet-stream)
2010-03-13 11:43 UTC, Robert Michel
Details

Description Robert Michel 2010-03-13 11:43:30 UTC
Created attachment 7196 [details]
Fix for SF_FormEdit.php special page to allow use of {{!}}

The feature to parse the pagename parameter of the info-tag to allow for more dynmic page titles was intoduced in SF 1.9.
However, this does not support more complex usage including parser functions like #if and #ifeq which use pipe characters.

I noticed the following behaviour:
* when extracting pagename=... it is cut off at the first occurrence of |
--> easy workaround is to use a template {{!}} instead of |
* now, templates do not get resolved by recursiveTagParse
--> workaround is to replace {{!}} just before calling the parser, which might not be the most elegant way, but works. This is what this patch does.

Other options could include:
* Change the extraction of the pagename value to respect additional {{, }} and | (probably more complex)
* try using preprocess instead of recursiveTagParse (not yet tested)
Comment 1 Yaron Koren 2010-12-29 16:03:44 UTC
This is now (finally) fixed in SVN, and the fix will go into the next SF version, 2.0.8 - you can now use normal pipes within #if statements and the like, and they'll be parsed correctly. Please try it out if you can, and feel free to re-open this bug if it's still a problem.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links