Last modified: 2012-04-19 21:43:33 UTC
Created attachment 7190 [details] Wiki_2010-03-12_LinkWithBrackers.pdf Reporting against Babaco Release : r63174 Tested link : http://prototype.wikimedia.org/deployment-en/ Steps to Reproduce :: 1) Select a link with brackets. Example : Falco (musician) 2) Press Insert <<Link create as [[Falco (musician)]] >> 3) Click on Show preview <<Link shows as Falco (musician) >> 4) Click on link to add another link 5) Select a link with brackets. Example : Falco (musician) 6) Remove Text to display 7) Press Insert <<Link create as [[Falco (musician)]] >> 8) Click on Show preview <<Link shows as Falco >> Expected Outcome:: Regardless the existence of Text to display field text, the link name should display as it is. Test Environment:: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.8) Gecko/20100202 Firefox/3.5.8 Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; InfoPath.3) Opera/9.63 (Windows NT 6.1; U; en) Presto/2.1.1 Opera/9.80 (Windows NT 6.1; U; en) Presto/2.2.15 Version/10.00 Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US) AppleWebKit/532.5 (KHTML, like Gecko) Chrome/4.0.249.89 Safari/532.5 Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US) AppleWebKit/530.17 (KHTML, like Gecko) Version/4.0 Safari/530.17
The links are not identical, the first is [[Falco (musician)]], the second [[Falco (musician)|]], with a pipe character (|) at the end. The fact that [[Falco (musician)|]] is converted to [[Falco (musician)|Falco]] is supposed to be a feature, called the pipe trick. Arguably, the pipe trick should not be triggered when the "text" field is empty; changing summary and CCing Parul and Naoko.
(In reply to comment #1) > The links are not identical, the first is [[Falco (musician)]], the second > [[Falco (musician)|]], with a pipe character (|) at the end. The fact that > [[Falco (musician)|]] is converted to [[Falco (musician)|Falco]] is supposed to > be a feature, called the pipe trick. > > Arguably, the pipe trick should not be triggered when the "text" field is > empty; changing summary and CCing Parul and Naoko. Can we not trigger the pipe when the text field is empty?
Fixed in r63868. We were making sure text got trimmed but not checking for it's length when it mattered.
Verified and close
