Last modified: 2012-05-23 20:47:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24770, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 22770 - wrap rights on GlobalGroupPermissions into a CSS class
wrap rights on GlobalGroupPermissions into a CSS class
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CentralAuth (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Victor Vasiliev
: easy, patch, patch-need-review
Depends on:
Blocks: 22771
  Show dependency treegraph
 
Reported: 2010-03-08 18:47 UTC by Umherirrender
Modified: 2012-05-23 20:47 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Added class for SpecialGlobalGroupPermissions (700 bytes, patch)
2010-03-14 22:58 UTC, Platonides
Details

Description Umherirrender 2010-03-08 18:47:45 UTC
Please wrap the right (for example '(edit)') into a class. Then
users can add own style. Thanks.

(see also bug 20014)
Comment 1 Platonides 2010-03-14 22:58:33 UTC
Created attachment 7198 [details]
Added class for SpecialGlobalGroupPermissions

What page are you talking about?
Special:GlobalGroupPermissions? The attached patch would add a new message parameter for that (note that $2 is used for links in the message and thus cannot get the class added to itself).
Comment 2 Umherirrender 2010-03-17 19:34:58 UTC
Yes, it is [[Special:GlobalGroupPermissions]]. Thanks for the hint.
Comment 3 Siebrand Mazeland 2010-04-20 23:00:05 UTC
Shouldn't this be done with some clever $wgOut->wrapWikiMsg()?
Comment 4 Platonides 2010-04-21 14:00:09 UTC
Can you use wrapWikiMsg here?

Note that the <li> are being added by (and it does seem right to do so without adding the * to the message). How would you perform it with wrapWikiMsg?
Also note that wrapWikiMsg uses parse, not parseinline.
Comment 5 DieBuche 2011-07-07 08:06:35 UTC
You don't need a class to style it.

.page-Special_GlobalGroupPermissions fieldset li {
color:red;
}
Comment 6 Umherirrender 2011-08-08 17:36:38 UTC
(In reply to comment #5)
> You don't need a class to style it.
> .page-Special_GlobalGroupPermissions fieldset li {
> color:red;
> }
That is wrong. I have to use the following and that per user right on [[Special:GlobalGroupPermissions]]

.page-Special_GlobalGroupPermissions_API_High_Limit_Requestor fieldset li label tt {
 background-color:blue;
}
Comment 7 Sumana Harihareswara 2012-04-19 15:42:05 UTC
Victor, could you take a look at this patch?  Thanks.
Comment 8 Sumana Harihareswara 2012-05-23 19:59:16 UTC
Platonides, can I ask you to submit this patch into Gerrit (with any updates as needed)? Thanks.
Comment 9 Platonides 2012-05-23 20:47:10 UTC
Turns out it has been commited since r66665 (May 2010)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links