Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T4271, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 2271 - Links replacement run for each image caption

Summary:	Links replacement run for each image caption

Status: RESOLVED FIXED Product: MediaWiki Classification: Unclassified Component: Parser (Other open bugs) Version: 1.5.x Hardware: All All Importance: Normal normal (vote) Target Milestone: --- Assigned To: Nobody - You can work on this! URL: Whiteboard: Keywords: Depends on: Blocks:   Show dependency tree / graph		Reported: 2005-05-31 07:32 UTC by JeLuF Modified: 2010-05-15 15:38 UTC (History) CC List: 0 users See Also: Web browser: --- Mobile Platform: --- Assignee Huggle Beta Tester: ---

Attachments Add an attachment (proposed patch, testcase, etc.)

Description JeLuF 2005-05-31 07:32:21 UTC 09:28 brion_: performance note in HEAD: it looks like the links replacement set is being fully run for each image caption. this seems to run a lot of duplicate make*LinkObj calls at the least (not sure about lookups) Comment 1 Brion Vibber 2005-05-31 08:51:00 UTC Now uses replaceLinkHoldersText() which doesn't do the unnecessary lookups and just inserts the text.