Last modified: 2010-02-17 00:52:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24540, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 22540 - Bug in caching thumbs for ForeignAPIRepo
Bug in caching thumbs for ForeignAPIRepo
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Chad H.
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-02-16 01:09 UTC by Derk-Jan Hartman
Modified: 2010-02-17 00:52 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
don't cache non-existent thumbs (1.44 KB, patch)
2010-02-16 01:09 UTC, Derk-Jan Hartman
Details
don't cache non-existent thumbs with corrected typo (1.44 KB, patch)
2010-02-16 09:37 UTC, Derk-Jan Hartman
Details
don't cache non-existent thumbs, with corrections (1.46 KB, patch)
2010-02-16 09:47 UTC, Derk-Jan Hartman
Details
don't cache non-existent thumbs, with corrections (1.38 KB, patch)
2010-02-16 14:45 UTC, Derk-Jan Hartman
Details

Description Derk-Jan Hartman 2010-02-16 01:09:35 UTC
Created attachment 7128 [details]
don't cache non-existent thumbs

There are some issues here with (non-existant) thumbs  that it is trying to cache. The attached patch should solve those.
Comment 1 Niklas Laxström 2010-02-16 07:06:28 UTC
Can you say what issues? There is typo in the patch:
> Could not downlaod
Also, don't use assignments inside comparison. In the future please mark patches as text/plain or tick the patch checkbox.
Comment 2 Derk-Jan Hartman 2010-02-16 09:35:07 UTC
Things like this:

[client ::1] PHP Warning: 
file_put_contents(/Users/hartman/Development/phase3/images/thumb/Accordian_chords-01.ogg/):
failed to open stream: Is a directory in
/Users/hartman/Development/phase3/includes/filerepo/ForeignAPIRepo.php on line
210, referer: http://localhost/wiki/index.php?title=Main_Page&action=edit

It tries to store a thumb, even though it hasn't found a thumb to store.
Comment 3 Derk-Jan Hartman 2010-02-16 09:37:40 UTC
Created attachment 7133 [details]
don't cache non-existent thumbs with corrected typo
Comment 4 Derk-Jan Hartman 2010-02-16 09:47:19 UTC
Created attachment 7134 [details]
don't cache non-existent thumbs, with corrections

don't use assignments inside comparison.
Comment 5 Derk-Jan Hartman 2010-02-16 14:45:32 UTC
Created attachment 7135 [details]
don't cache non-existent thumbs, with corrections

'compile before you submit' ... :/
Comment 6 Chad H. 2010-02-17 00:52:19 UTC
Fixed in r62634

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links