Last modified: 2011-01-25 01:21:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24538, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 22538 - Slightly improve native player of FF/Chrome
Slightly improve native player of FF/Chrome
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
OggHandler (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Tim Starling
: easy, patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-02-15 21:12 UTC by Derk-Jan Hartman
Modified: 2011-01-25 01:21 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
remove width setting on div surrounding player and options. (461 bytes, patch)
2010-02-15 21:12 UTC, Derk-Jan Hartman
Details

Description Derk-Jan Hartman 2010-02-15 21:12:21 UTC
Created attachment 7126 [details]
remove width setting on div surrounding player and options.

The native a/v players of FireFox and Chrome, have a minimum width that is rather larger. Many times Wikipedia requests players sizes that are much more slim. This creates problems when users of those browsers visit these pages. The player far extends outside the thumb or template box (See Template:Listen). mwEmbed solves this with a 'custom' player, but there is a quick fix for most usecases.

The div around the player has a fixed width at all times. This fixed width is not really needed. In thumb mode, it is not needed at all, because the thumb box already has a fixed width, and in noicon mode (the most used mode for audio/video)  there is no need for a width restriction.

I propose the attached patch, which removes the width property. This has no effect for thumb modes, while solving the issue of the native players in noicon mode.

Tested with native mode, QT and Cortado.
Comment 1 Aryeh Gregor (not reading bugmail, please e-mail directly) 2010-02-19 19:25:07 UTC
I wasn't able to test this, since I can't get Ogg uploads working locally.  It seems to be a reasonable change in principle, though . . .
Comment 2 Derk-Jan Hartman 2010-05-16 00:26:40 UTC
Fixed in r66505

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links