Last modified: 2010-02-16 03:38:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24501, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 22501 - DISPLAYTITLE broken in trunk
DISPLAYTITLE broken in trunk
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-02-12 21:52 UTC by MZMcBride
Modified: 2010-02-16 03:38 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MZMcBride 2010-02-12 21:52:48 UTC
Per the comments here https://jira.toolserver.org/browse/TS-511 DISPLAYTITLE appears to be broken in trunk.
Comment 1 Alexandre Emsenhuber [IAlex] 2010-02-12 22:22:31 UTC
Added a note on code review that this seems to be caused either by r60832 or r61101: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/60832#c5762
Comment 2 Conrad Irwin 2010-02-15 16:52:34 UTC
enhancement -> major. As of r61101 the parser sets the default title every time it is run now; so it gets overwritten by parsing system messages (or indeed anything else) after the page has been parsed. Not sure the best way to fix.
Comment 3 Aryeh Gregor (not reading bugmail, please e-mail directly) 2010-02-15 21:43:52 UTC
Why don't we just revert r61101?
Comment 4 Mark A. Hershberger 2010-02-15 22:46:12 UTC
fixed in r62539
Comment 5 Conrad Irwin 2010-02-15 22:55:53 UTC
Still seems broken with $wgRestrictDisplayTitle = true; - maybe not directly related to r61101 though.

Also it seems your fix will not work if getConvLangTitle() doesn't return false (though I haven't tested)
Comment 6 Mark A. Hershberger 2010-02-15 23:33:07 UTC
getConvRuleTitle() will only return a non-false value (a conversion title) if -{T}- is specified.  This is similar to DISPLAYTITLE.
Comment 7 Mark A. Hershberger 2010-02-15 23:55:51 UTC
I've provided a few more tests in r62558 that should show it works in the case that wgRestrictDisplayTitle = true.  If those tests are correct, could you please re-close the bug?  Otherwise, let me know what the problem is.
Comment 8 Aryeh Gregor (not reading bugmail, please e-mail directly) 2010-02-16 00:08:53 UTC
Something seems wrong on preview -- entering {{DISPLAYTITLE:main Page}} on [[Main Page]] and previewing gives "Editing" as the page title.  It seems to work on actual page views.
Comment 9 Mark A. Hershberger 2010-02-16 00:25:16 UTC
after r61101, preview shows just "Main Page" with no "Editting " prefix.   Tracking it down...
Comment 10 Conrad Irwin 2010-02-16 00:31:01 UTC
One last thing, shouldn't the parser tests showtitle show the original when it has not been overridden (at the moment it is blank)? Thanks for dealing with this.
Comment 11 Mark A. Hershberger 2010-02-16 03:38:53 UTC
fixed in r62577

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links