Last modified: 2006-10-21 23:32:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T4241, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 2241 - Colliding duplicate use of 'w' and 'd' shortcut keys
Colliding duplicate use of 'w' and 'd' shortcut keys
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal minor with 3 votes (vote)
: ---
Assigned To: Rob Church
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-05-24 14:55 UTC by Puzzlet Chung
Modified: 2006-10-21 23:32 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch for 'w' conflict (888 bytes, patch)
2006-08-10 03:08 UTC, Aryeh Gregor (not reading bugmail, please e-mail directly)
Details
Alternative 'w' patch (707 bytes, patch)
2006-08-10 03:37 UTC, Aryeh Gregor (not reading bugmail, please e-mail directly)
Details
Fix 'd' collision for remaining languages (5.86 KB, patch)
2006-08-10 07:02 UTC, Aryeh Gregor (not reading bugmail, please e-mail directly)
Details
Fix 'd' collision for remaining languages (including ga) (6.38 KB, patch)
2006-08-10 07:06 UTC, Aryeh Gregor (not reading bugmail, please e-mail directly)
Details

Description Puzzlet Chung 2005-05-24 14:55:54 UTC
Both general "Watch" link and "Watch this page" checkbox just under the edit box
have shortcut key alt+w.
Comment 1 Raimond Spekking 2006-05-27 12:47:08 UTC
It would be great if there will be a solution in the near future :)  I think,
alt-w should be kept for the "Watch"-link. alt-v seems to be available and to be
used for the checkbox.
Comment 2 Raimond Spekking 2006-06-05 11:28:42 UTC
Just another duplicate usage, but only for admins a problem: alt-d is used for
the delete-tab and "show changes" at the edit-modus.
Comment 3 Aryeh Gregor (not reading bugmail, please e-mail directly) 2006-08-10 03:08:35 UTC
Created attachment 2209 [details]
Patch for 'w' conflict

This patch simply removes the watch/unwatch tab in edit mode.  This is probably
desirable in any case, and so is normal behavior in non-Monobook-based skins
already: clicking the (un)watch button does nothing if you subsequently save
the submission form you have open, since it's silently overridden by the status
of the checkbox.
Comment 4 Aryeh Gregor (not reading bugmail, please e-mail directly) 2006-08-10 03:37:47 UTC
Created attachment 2210 [details]
Alternative 'w' patch

This is an alternative patch that just removes the accesskey from the
watch/unwatch tab during editing, rather than removing the tab altogether.  So
if you press alt-W while editing, it just checks/unchecks the box.
Comment 5 Aryeh Gregor (not reading bugmail, please e-mail directly) 2006-08-10 06:39:44 UTC
The 'd' collision was fixed eleven months ago in r10460.  The shortcut for "show
changes" has been 'v' for almost a year.
Comment 6 Aryeh Gregor (not reading bugmail, please e-mail directly) 2006-08-10 07:02:24 UTC
Created attachment 2211 [details]
Fix 'd' collision for remaining languages

(In reply to comment #5)
> The 'd' collision was fixed eleven months ago in r10460.  The shortcut for
"show
> changes" has been 'v' for almost a year.

Correction: it was fixed for *some* languages.	Cs, da, de, el, eu, it, ja, mk,
nn, pms, and sk are all still using 'd'.
Comment 7 Aryeh Gregor (not reading bugmail, please e-mail directly) 2006-08-10 07:06:43 UTC
Created attachment 2212 [details]
Fix 'd' collision for remaining languages (including ga)

Whoops, left out ga.
Comment 8 Aryeh Gregor (not reading bugmail, please e-mail directly) 2006-10-13 07:13:56 UTC
'w' collision fixed in r16989 (per comment #3).  'd' collision remains.
Comment 9 Brion Vibber 2006-10-13 21:04:36 UTC
Reverted r16989, as it made it more or less impossible to watch/unwatch a page that 
doesn't presently exist without manually mucking about with URLs.
Comment 10 Aryeh Gregor (not reading bugmail, please e-mail directly) 2006-10-20 02:44:47 UTC
Both collisions fixed in r17118.
Comment 11 Raimond Spekking 2006-10-20 17:51:49 UTC
[[MediaWiki:tooltip-diff]] has to to changed too, at least for de:
Comment 12 Jimmy Collins 2006-10-21 22:58:02 UTC
(In reply to comment #11)
> [[MediaWiki:tooltip-diff]] has to to changed too, at least for de:

Done in r17164.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links