Last modified: 2010-02-10 13:21:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24393, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 22393 - Charinsert / Edittools (the old one) does not work
Charinsert / Edittools (the old one) does not work
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UsabilityInitiative (Other open bugs)
unspecified
All All
: High major with 1 vote (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-02-05 13:15 UTC by Raimond Spekking
Modified: 2010-02-10 13:21 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Raimond Spekking 2010-02-05 13:15:54 UTC
Firefox 3.6/Windows 7 on dewiki:

Inserting characters via the (old) Edittools/charinsert extension ([[de:MediaWiki:Onlyifediting.js]] does not longer work after deploying the latest UI changes to dewiki.

This extension is still needed to insert characters/code markup not part of the new Edittoolbar.
Comment 1 Derk-Jan Hartman 2010-02-09 11:06:54 UTC
The same problem existed on the English Wikipedia, where the following fix was deployed as suggested by Trevor.

http://en.wikipedia.org/w/index.php?title=MediaWiki:Edittools.js&curid=17396845&diff=342909291&oldid=340525133

A similar change is probably needed for the German Wikipedia version.
Comment 2 Calcey QA 2010-02-09 11:35:40 UTC
As per http://www.mediawiki.org/wiki/Extension:CharInsert there should be a setting to be done in LocalSettings.php file. Appreciate if you can let me know whether it's done at the server end.
Comment 3 Roan Kattouw 2010-02-09 13:52:47 UTC
(In reply to comment #2)
> As per http://www.mediawiki.org/wiki/Extension:CharInsert there should be a
> setting to be done in LocalSettings.php file. Appreciate if you can let me know
> whether it's done at the server end.

That's for installing CharInsert, which happened years ago. The setting that does need to be changed is in MediaWiki:Edittool.js ; this happened on English Wikipedia (and possibly other wikis as well), so you can test there.
Comment 4 Raimond Spekking 2010-02-09 16:04:13 UTC
(In reply to comment #1)
> The same problem existed on the English Wikipedia, where the following fix was
> deployed as suggested by Trevor.
> 
> http://en.wikipedia.org/w/index.php?title=MediaWiki:Edittools.js&curid=17396845&diff=342909291&oldid=340525133
> 
> A similar change is probably needed for the German Wikipedia version.

Above code from enwiki applied on dewiki.

Results:
* Firefox 3.6 and Opera 10.10: Edittools disappeared
* Chrom 4.0.249.78: Edittools still there but non-functional.
Comment 5 Roan Kattouw 2010-02-09 16:33:48 UTC
(In reply to comment #4)
> (In reply to comment #1)
> > The same problem existed on the English Wikipedia, where the following fix was
> > deployed as suggested by Trevor.
> > 
> > http://en.wikipedia.org/w/index.php?title=MediaWiki:Edittools.js&curid=17396845&diff=342909291&oldid=340525133
> > 
> > A similar change is probably needed for the German Wikipedia version.
> 
> Above code from enwiki applied on dewiki.
> 
> Results:
> * Firefox 3.6 and Opera 10.10: Edittools disappeared
> * Chrom 4.0.249.78: Edittools still there but non-functional.

That's because you pasted it in the wrong place. The code thedj inserted on enwiki is context-sensitive and can't just be thrown in anywhere.

Because dewiki doesn't override insertTags, it'll have to wait for a similar fix to edit.js to be deployed. This'll hopefully happen today.
Comment 6 Trevor Parscal 2010-02-09 21:00:43 UTC
This has been deployed.
Comment 7 Calcey QA 2010-02-10 11:00:25 UTC
This is not able to verify since the user account do not have sufficient authorization to follow the steps given in http://en.wikipedia.org/wiki/MediaWiki:Edittools.js
Comment 8 Roan Kattouw 2010-02-10 11:53:50 UTC
(In reply to comment #7)
> This is not able to verify since the user account do not have sufficient
> authorization to follow the steps given in
> http://en.wikipedia.org/wiki/MediaWiki:Edittools.js

You don't need to do any magic there, you can just test whether the feature works or not.
Comment 9 Strainu 2010-02-10 13:21:32 UTC
I can confirm it works on ro.wp. I noticed this problem yesterday and I was looking for the bug. :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links