Last modified: 2010-02-05 21:07:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24389, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 22389 - js insertion after posting comment on talk page
js insertion after posting comment on talk page
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
unspecified
PC other
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-02-05 01:14 UTC by when_babies_attack
Modified: 2010-02-05 21:07 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description when_babies_attack 2010-02-05 01:14:07 UTC
After leaving a message on a user's talk page, a bunch of JavaScript got appended to it.  See: http://en.wikipedia.org/w/index.php?title=User_talk:Gigs&action=historysubmit&diff=342006772&oldid=341890610

Win7 64bit, Core2 Duo on a dell XPS 1330, Google Chrome 4.0.249.78 (36714). MSE antivirus.

First time this has happened. Was working perfectly earlier today. Bug occurs on my talk page as well: http://en.wikipedia.org/wiki/User_talk:Throwaway85#test
Comment 1 when_babies_attack 2010-02-05 05:21:30 UTC
Confirmed change has not occurred as a result of tampering with scripts in monobook.js -t85
Comment 2 when_babies_attack 2010-02-05 06:10:30 UTC
This issue is confined to Chrome, does not occur with FireFox.  Will file similar report w/ google.
Comment 3 Bawolff (Brian Wolff) 2010-02-05 06:14:32 UTC
In order to narrow it down, does it still happen when not logged in, if it only happens when logged in, does it stop happening when you disable any gadgets you had enabled and clear special:mypage/monobook.js ? (aka try to narrow down if its a wikipedia issue or a mediawiki one).
Comment 4 when_babies_attack 2010-02-05 20:49:06 UTC
So it doesn't happen while logged out, but it still occurs when I clear my monobook and disable all gadgets: http://en.wikipedia.org/w/index.php?title=User_talk:Throwaway85&action=historysubmit&diff=342159175&oldid=342158599

Still only happens on Chrome, and apparently still only happens to me.  I know that makes it nearly impossible to replicate/fix.  Still occurs after a fresh install of Chrome.  If there's any other info I can give you, let me know.
Comment 5 Conrad Irwin 2010-02-05 20:58:32 UTC
See also http://en.wikipedia.org/w/index.php?title=Paul_Cuffee&action=historysubmit&diff=342038823&oldid=342031830 (I have informed User:Moorlock as well). 

Does this happen on other sites than Wikipedia, it's possible you have something more wrong than some Wikipedia javascript. 

There seem to be a few instances of this occuring on other sites:

http://www.google.co.uk/search?q=g+try{for(var+lastpass_iter%3D0%3B+lastpass_iter+<+document.forms.length%3B+lastpass_iter%2B%2B){+var+lastpass_f+%3D+document.forms[lastpass_iter]%3B&hl=en&safe=off&client=firefox-a&rls=org.mozilla:en-GB:official&hs=GiV&filter=0
Comment 6 Conrad Irwin 2010-02-05 21:04:39 UTC
Oh, let's be cleverer about this. The javascript mentions "lastpass" which is a chrome plugin - do you happen to have that? If so, you'll have to go and get the author of that to fix it. (And I'd strongly recommend not using anything so buggy to store passwords).
Comment 7 when_babies_attack 2010-02-05 21:07:15 UTC
Well shit son, I do indeed.  Weird.  I was confused as to why LastPass for Chrome seemed to be much, much worse than LastPass for Firefox.  Hell, *everything* for Chrome is worse than its ff equivalent.  Alright, I'll take the issue up with their devs.  Thanks for your help.
Comment 8 Conrad Irwin 2010-02-05 21:07:49 UTC
No worries!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links