Last modified: 2010-02-01 03:18:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24331, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 22331 - OutputPage looks for wikibits.js, even if skins content is elsewhere.
OutputPage looks for wikibits.js, even if skins content is elsewhere.
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.16.x
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-01-31 15:16 UTC by John Morton
Modified: 2010-02-01 03:18 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description John Morton 2010-01-31 15:16:43 UTC
I'm using a $wgStylePath set to an absolute URL, so I can place static media on a separate domain. My original deployment scripts placed skins/*.php on the mediawiki serving domain and the subdirectories on the static, but that resulted in this error:

Warning:  filemtime() [function.filemtime<]: stat failed for /home/cffc/webapps/htdocs/w/skins/common/wikibits.js in /home/cffc/webapps/htdocs/w/includes/OutputPage.php on line 301

This looks like a new feature designed to force reloading of some media components if the file has changed, which seems to be half baked — only wikibits.js triggers this code path; ajax.js and the skin related media is unaffected — and duplicates what a properly configured web server should be capable of doing by itself. 

I would prefer a move towards better support for serving static media on separate domains, where far future expiry times plus the query argument revision should be sufficient to trigger a cache update. 

(Though one revision flag for the mediawiki common media, and a per skin revision would be a better combination.)
Comment 1 Roan Kattouw 2010-01-31 15:35:58 UTC
Which version of MW are you using? What's on OutputPage.php line 301? The bug was filed against version 1.16-svn, but I only see a brace on OutputPage.php line 301 in r61744 and versions 1.6-1.15 don't seem to contain a call to filemtime() in OutputPage.php .
Comment 2 John Morton 2010-02-01 03:18:17 UTC
I thought I was running the latest trunk, but I was wildly out of date. Looks like that code is gone completely, as the problem doesn't manifest, now.

Looking forward to 1.16 :-)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links