Last modified: 2010-01-29 17:30:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24315, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 22315 - hook SpecialRecentChangesQuery should pass $query_options ; and respect return value
hook SpecialRecentChangesQuery should pass $query_options ; and respect retur...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Recent changes (Other open bugs)
1.16.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://svn.wikimedia.org/viewvc/media...
: patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-01-29 08:10 UTC by T. Gries
Modified: 2010-01-29 17:30 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
diff patch (721 bytes, application/octet-stream)
2010-01-29 08:10 UTC, T. Gries
Details
diff patch (721 bytes, patch)
2010-01-29 08:10 UTC, T. Gries
Details

Description T. Gries 2010-01-29 08:10:31 UTC
Created attachment 7047 [details]
diff patch

In SpecialRecentChangesQuery function doMainQuery hook parameters should also pass $query_options to enable external modification such as 'group by rc_namespace, rc_title'

wfRunHooks('SpecialRecentChangesQuery', array( &$conds, &$tables, &$join_conds, $opts ) );

 ==>

wfRunHooks('SpecialRecentChangesQuery', array( &$conds, &$tables, &$join_conds, $opts, &$query_options ) );

The hook call lacks also checking the return value (a false return value should skip/abort further processing in case the extension took over processing).
Comment 1 T. Gries 2010-01-29 08:10:58 UTC
Created attachment 7048 [details]
diff patch
Comment 2 Alexandre Emsenhuber [IAlex] 2010-01-29 17:28:14 UTC
Fixed in r61670.
Comment 3 T. Gries 2010-01-29 17:30:42 UTC
danke

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links