Last modified: 2010-02-10 09:37:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24311, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 22311 - Tabbing from the editor should go to the edit summary field
Tabbing from the editor should go to the edit summary field
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UsabilityInitiative (Other open bugs)
unspecified
All All
: Normal trivial (vote)
: ---
Assigned To: Adam Miller
:
: 22396 22397 22417 22438 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-01-29 01:14 UTC by Alex Z.
Modified: 2010-02-10 09:37 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Wiki_bug_2010-02-09_22311.pdf (82.86 KB, application/pdf)
2010-02-09 08:10 UTC, Calcey QA 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Alex Z. 2010-01-29 01:14:41 UTC 
In the normal textarea, pressing Tab will move the cursor to the edit summary field. Using the WikiEditor editor, it goes to the next focusable element, which in most cases (including the MediaWiki default) is a link to the copyright page.

Tabbing should go from the Wikieditor to the edit summary field.

Tested r61651 on Firefox 3.5.6 on Fedora 11
Comment 1 Roan Kattouw 2010-01-29 17:19:26 UTC 
Should be trivial: setting the tabindex on the <iframe> equal to the one on the <textarea> should do it.
Comment 2 Raimond Spekking 2010-02-05 13:47:11 UTC 
See r62022 for a tabindex fix in core.
Comment 3 Raimond Spekking 2010-02-05 17:00:28 UTC 
*** Bug 22396 has been marked as a duplicate of this bug. ***
Comment 4 Roan Kattouw 2010-02-08 16:31:43 UTC 
*** Bug 22397 has been marked as a duplicate of this bug. ***
Comment 5 Roan Kattouw 2010-02-08 16:33:13 UTC 
(In reply to comment #2)
> See r62022 for a tabindex fix in core.

This "fix" doesn't do anything (see CR) and is unrelated to this bug.

(In reply to comment #4)
> *** Bug 22397 has been marked as a duplicate of this bug. ***
This report mentioned that tabbing back (Shift+Tab) from the iframe should go to the section title box on section=new . This is also due to the lack of a tabindex attribute.
Comment 6 Adam Miller 2010-02-08 16:59:08 UTC 
Added a tabindex to the iframe in r62127 in hopes for addressing this concern.
Comment 7 Roan Kattouw 2010-02-08 19:07:43 UTC 
*** Bug 22417 has been marked as a duplicate of this bug. ***
Comment 8 Roan Kattouw 2010-02-08 21:11:17 UTC 
*** Bug 22438 has been marked as a duplicate of this bug. ***
Comment 9 Roan Kattouw 2010-02-08 21:12:09 UTC 
(In reply to comment #8)
> *** Bug 22438 has been marked as a duplicate of this bug. ***
Per this report Chrome inserts a literal tab character when Tab is pressed.
Comment 10 Calcey QA 2010-02-09 08:10:16 UTC 
Created attachment 7090 [details]
Wiki_bug_2010-02-09_22311.pdf


The tab is not pointing to Edit summary on Chrome 4 and Safari 5 browsers.
Comment 11 Adam Miller 2010-02-09 15:35:25 UTC 
Assuming you meant Safari 4. 

You may have been viewing old code on prototype. It's working for me right now in Safari 4 and Chrome 4. Please check it out again.
Comment 12 Tisza Gergő 2010-02-09 19:34:00 UTC 
(In reply to comment #11)
Indeed, after emptying the cache, it works correctly now on Wikipedia under Chrome.
Comment 13 Roan Kattouw 2010-02-09 19:37:08 UTC 
(In reply to comment #12)
> (In reply to comment #11)
> Indeed, after emptying the cache, it works correctly now on Wikipedia under
> Chrome.

The fix was deployed a few hours ago, thanks for confirming.
Comment 14 Calcey QA 2010-02-10 09:37:38 UTC 
Tested link : http://prototype.wikimedia.org/deployment-en/
Version : r62215

Fix verified
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links