Last modified: 2010-02-23 02:04:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24268, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 22268 - LocalSettings.php $wgHTTPProxy should take default value from environment variable $http_proxy if present
LocalSettings.php $wgHTTPProxy should take default value from environment var...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.16.x
All All
: Normal normal (vote)
: ---
Assigned To: Mark A. Hershberger
http://svn.wikimedia.org/viewvc/media...
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-01-25 19:54 UTC by T. Gries
Modified: 2010-02-23 02:04 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
diff / patch (493 bytes, patch)
2010-01-25 19:54 UTC, T. Gries 		Details
Add an attachment (proposed patch, testcase, etc.)

Description T. Gries 2010-01-25 19:54:28 UTC 
I suggest an improvement so that the variable $wgHTTPProxy - which is needed for curl calls for example for uploading files from external urls - is initialized from environement variable $http_proxy (if present).

Diff/Patch follows
Comment 1 T. Gries 2010-01-25 19:54:59 UTC 
Created attachment 7016 [details]
diff / patch
Comment 3 Chad H. 2010-02-15 12:51:00 UTC 
Suggest WONTFIX. Just because an environment variable named http_proxy has been set does not mean the wiki needs to use it for external HTTP connections.
Comment 4 Mark A. Hershberger 2010-02-17 07:28:32 UTC 
It might not be useful for the Wiki, but is probably useful for the CLI utilities.
Comment 5 T. Gries 2010-02-17 19:40:30 UTC 
(In reply to comment #4)
> It might not be useful for the Wiki, but is probably useful for the CLI
> utilities.

(In reply to comment #3)
> Suggest WONTFIX. Just because an environment variable named http_proxy has been
> set does not mean the wiki needs to use it for external HTTP connections.

This setting (or another one which supplies the proxy address) _is_ needed for the curl call (side-upload  of a file = upload a file by its URL) when proxy settings are needed for the server where the mediawiki lives. See inside http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/HttpFunctions.php?view=markup
Comment 6 Mark A. Hershberger 2010-02-22 05:13:40 UTC 
fixed in r62811
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links