Last modified: 2014-09-23 23:07:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24231, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 22231 - Table updaters should warn (and offer deletion) of empty image.img_name or image.img_size rows
Table updaters should warn (and offer deletion) of empty image.img_name or im...
Status: NEW
Product: MediaWiki
Classification: Unclassified
Maintenance scripts (Other open bugs)
1.16.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
http://svn.wikimedia.org/viewvc/media...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-01-22 22:06 UTC by T. Gries
Modified: 2014-09-23 23:07 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description T. Gries 2010-01-22 22:06:09 UTC
Recently I found a small problem after upgrading a very old version to Mediawiki 1.15.1, this problem being entered as https://bugzilla.wikimedia.org/show_bug.cgi?id=22227 (SpecialListfiles throws fatal error on emtpy file names).

But the underlying reason was a failed file upload some years ago which apparently resulted in a "upload zombie" entry in table image (the failing upload is not topic of this bugzilla as such. We all know, this should not happen, but happened for the one or other reason now and then in older Mediawiki versions.)

In my case, I found that the upload date and uploader's name were present and correct, but I found image.img_name == '' and image.img_size==0, which make no sense and puzzles at least SpecialListfiles.php (try to sort the table by names -> fatal error).

To offer users a safe migration in case they have previously unknown "upload zombie(s)" in their image table, I suggest:

--> to add a check in updaters.inc to print a warning for such cases. It will be needed to add a quick plausibility check and to give the updater a link to delete such zombies when migrate-installing a wiki, or when maintaining database.
Comment 1 Chad H. 2011-04-26 12:51:10 UTC
Unassigning myself.
Comment 2 Sumana Harihareswara 2011-11-09 02:51:16 UTC
Removing the "need-review" keyword, since there is no patch here awaiting code review.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links