Last modified: 2014-09-24 00:06:26 UTC
While debugging another module (the Interwiki extension which says in the table of interwiki links "edit this page" instead of simply "edit), I found what looks to be an old message string text bug in the core OutputPage.php: In OutputPage.php public function output line 942 seq. I found if( $wgUniversalEditButton ) { .... title' => wfMsg( 'edit' ), .... 'title' => wfMsg( 'edit' ), I am pretty sure that here twice 'editthispage' was originall meant (but pls. review and correct me, if I am wrong). Remark: compare with Skin.php function editThisPage which uses the correct message string "editthispage" is used.
A similar change in SkinTemplate.php line 688 is needed .... 'text' => $this->mTitle->exists() ? wfMsg( 'edit' ) : wfMsg( 'create' ), 'href' => $this->mTitle->getLocalUrl( $this->editUrlOptions() ) change wfMsg( 'edit' ) to wfMsg( 'editthispage' )
The original message was editthispage ("Edit this page"), edit was added on r2810 for the tal-based davinci skin. Then on r10386 avar changed editthispage to also be "Edit" So nuking it seems a good idea.
(In reply to comment #2) > The original message was editthispage ("Edit this page"), edit was added on > r2810 for the tal-based davinci skin. > Then on r10386 avar changed editthispage to also be "Edit" > > So nuking it seems a good idea. Further analysis enwiki: - http://en.wikipedia.org/wiki/MediaWiki:Editthispage = Editthispage (text correct) - http://en.wikipedia.org/wiki/MediaWiki:Edit = Editthispage (text not correct, but currently needed to show "edit this page" on all editable pages due to the here-reported bug) Possible side effect and impact: all Language/Messages files need perhaps also be reviewed in their text elements for 'edit'.
Removing the keyword "need-review" since we're using that for bugs that have patches (that need code review) attached.
