Last modified: 2014-09-24 00:06:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 22229 - OutputPage.php function output: use wfMsg( 'editthispage' ) instead of ( 'edit' )
OutputPage.php function output: use wfMsg( 'editthispage' ) instead of ( 'edi...
Status: NEW
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.16.x
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://svn.wikimedia.org/viewvc/media...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-01-22 21:26 UTC by T. Gries
Modified: 2014-09-24 00:06 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description T. Gries 2010-01-22 21:26:38 UTC
While debugging another module (the Interwiki extension which says in the table of interwiki links "edit this page" instead of simply "edit), I found what looks to be an old message string text bug in the core OutputPage.php:

In OutputPage.php public function output line 942 seq. I found

if( $wgUniversalEditButton ) {
....
title' => wfMsg( 'edit' ),
....
'title' => wfMsg( 'edit' ),
		

I am pretty sure that here twice 'editthispage' was originall meant (but pls. review and correct me, if I am wrong). 

Remark: compare with Skin.php function editThisPage which uses the correct message string "editthispage" is used.
Comment 1 T. Gries 2010-01-22 21:37:27 UTC
A similar change in SkinTemplate.php line 688 is needed

....
'text' => $this->mTitle->exists()
		? wfMsg( 'edit' )
		: wfMsg( 'create' ),
		'href' => $this->mTitle->getLocalUrl( $this->editUrlOptions() )


change  wfMsg( 'edit' ) to wfMsg( 'editthispage' )
Comment 2 Platonides 2010-01-22 21:53:52 UTC
The original message was editthispage ("Edit this page"), edit was added on r2810 for the tal-based davinci skin.
Then on r10386 avar changed editthispage to also be "Edit"

So nuking it seems a good idea.
Comment 3 T. Gries 2010-01-22 22:16:50 UTC
(In reply to comment #2)
> The original message was editthispage ("Edit this page"), edit was added on
> r2810 for the tal-based davinci skin.
> Then on r10386 avar changed editthispage to also be "Edit"
> 
> So nuking it seems a good idea.

Further analysis enwiki:
- http://en.wikipedia.org/wiki/MediaWiki:Editthispage = Editthispage (text correct)
- http://en.wikipedia.org/wiki/MediaWiki:Edit = Editthispage (text not correct, but currently needed to show "edit this page" on all editable pages due to the here-reported bug)

Possible side effect and impact: all Language/Messages files need perhaps also be reviewed in their text elements for 'edit'.
Comment 4 Sumana Harihareswara 2011-11-09 02:52:57 UTC
Removing the keyword "need-review" since we're using that for bugs that have patches (that need code review) attached.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links