Last modified: 2010-01-22 21:19:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24221, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 22221 - Special:Interwiki's description on Special:SpecialPages should not say "and edit" for users not having "interwiki" right
Special:Interwiki's description on Special:SpecialPages should not say "and e...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Interwiki (extension) (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: X!
http://www.mediawiki.org/wiki/Extensi...
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-01-21 23:18 UTC by T. Gries
Modified: 2010-01-22 21:19 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
diff patch (528 bytes, application/octet-stream)
2010-01-21 23:18 UTC, T. Gries
Details
patch (528 bytes, patch)
2010-01-21 23:19 UTC, T. Gries
Details

Description T. Gries 2010-01-21 23:18:07 UTC
Created attachment 7002 [details]
diff patch

In http://svn.wikimedia.org/viewvc/mediawiki?view=rev&revision=59347 the second parameter (restriction) is missing and should be set to "interwiki". Then the Special Page extension is only shown and executed for users having that permission.
Comment 1 T. Gries 2010-01-21 23:19:24 UTC
Created attachment 7003 [details]
patch
Comment 2 Alexandre Emsenhuber [IAlex] 2010-01-22 20:12:27 UTC
"interwiki" right allows users to edit entries, users without that right can still access the page to see the list of prefixes. Adding this restriction to the constructor would remove the page from Special:SpecialPages even for users able to access it.
Comment 3 T. Gries 2010-01-22 20:55:06 UTC
(In reply to comment #2)
> "interwiki" right allows users to edit entries, users without that right can
> still access the page to see the list of prefixes.
Okay, you are right in this respect. 

I investigated and found a remaining problem (which puzzled me first). This is the text text on Special:Pages still saying for all users "View and edit interwiki data" - which is incorrect for those majority of users without "interwiki" permission.

For such users the text need to be "View interwiki data" (without "and edit").

In order not to make it too complicate I suggest:

to change the text "View and edit interwiki data" to something neutral like --> "Interwiki data"
Comment 4 Alexandre Emsenhuber [IAlex] 2010-01-22 21:19:21 UTC
Done in r61394.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links