Last modified: 2010-03-17 23:40:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24184, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 22184 - geocode and type coordinates not compatible
geocode and type coordinates not compatible
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
SemanticMaps (Other open bugs)
unspecified
All All
: Normal normal with 2 votes (vote)
: ---
Assigned To: Jeroen De Dauw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-01-20 10:17 UTC by DaSch
Modified: 2010-03-17 23:40 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
FIX/Workaround (1.19 KB, patch)
2010-02-11 18:52 UTC, DaSch
Details

Description DaSch 2010-01-20 10:17:44 UTC
The value #geocode from the Maps extension returns is not compatible with the input the type coordinates accepts
Comment 1 Jeroen De Dauw 2010-01-20 16:03:10 UTC
(In reply to comment #0)
> The value #geocode from the Maps extension returns is not compatible with the
> input the type coordinates accepts

It is on my wiki. What version of Maps, SM and SMW are you using? Can you provide a link to an example of this behaviour?
Comment 2 DaSch 2010-01-22 16:42:29 UTC
Versions:
MW: 1.16alpha (r61264)
Maps: 0.5.3 a2 (r61363)
SMW: 1.5g-SVN (r60520)
SM: 0.5.3 a2 (r61363)

PHP: 5.2.4-2ubuntu5.10 (apache2handler)
MySQL: 	5.0.51a-3ubuntu5.4

Example:
http://www.wecowi.de/view/WeCoWi:Bugs/22184
Comment 3 Jeroen De Dauw 2010-01-22 20:29:33 UTC
(In reply to comment #2)
> Versions:
> MW: 1.16alpha (r61264)
> Maps: 0.5.3 a2 (r61363)
> SMW: 1.5g-SVN (r60520)
> SM: 0.5.3 a2 (r61363)
> 
> PHP: 5.2.4-2ubuntu5.10 (apache2handler)
> MySQL:     5.0.51a-3ubuntu5.4
> 
> Example:
> http://www.wecowi.de/view/WeCoWi:Bugs/22184

Hey,

It's working fine on mine, and other, wiki's as far as I can determine. See the source of http://wiki.bn2vs.com/Berlin for an example.
Comment 4 DaSch 2010-01-22 20:43:10 UTC
Localisation? Maybe this is an issue about . and , as different seperators in different Language. I Fear you only tested on english wikis
Comment 5 Jeroen De Dauw 2010-01-22 21:51:39 UTC
(In reply to comment #4)
> Localisation? Maybe this is an issue about . and , as different seperators in
> different Language. I Fear you only tested on english wikis

That could be right. #Geocode is not internationalized, so if the geo property of SMW is, that'll indeed give problems. Can you confirm this is the case?
Comment 6 DaSch 2010-01-23 16:49:29 UTC
when changing wgLanguageCode from de to en it works. So it's a problem with the localisation.
Comment 7 DaSch 2010-02-10 10:44:55 UTC
isn't it possible to make #geocode work with the built-in-features of SMW, or maybe give an output that is understood by SMW in all languages the same way.

The user in my wiki are already complaining about the incompatibility of #geocode an the SMW-Coordinates function
Comment 8 Jeroen De Dauw 2010-02-10 19:21:25 UTC
Geocode can not hold into account the SMW stuff, since Geocode is part of Maps, which does not required SMW. It's ofcourse possible to modify the formats so SMW does recognize float coordinates, but I did not write the code responsible for that, and am not planning to try to fix this any time soon due to other work.
Comment 9 DaSch 2010-02-11 08:58:37 UTC
well cause you seem not to be able to create a fix for this I made a for line fix, took me an hour to find the place to insert and 5 Minutes to insert the fix.

I fix close this as later, cause I think you have no interest to provide a working software for non english users
Comment 10 Jeroen De Dauw 2010-02-11 17:30:27 UTC
Hey,

If you created a fix - awesome. I'd be happy to apply it to the code (unless you can do it yourself ofcourse).

"I think you have no interest to provide a working software for non english users" - A little unfair considering I developed a lot of the code in my free time no?
Comment 11 DaSch 2010-02-11 18:52:49 UTC
Created attachment 7107 [details]
FIX/Workaround

Well sry, I was a bit frustrated this morning, after filling the whole Maps code with wfDebug to find out where I have to put in my code to corret the problem

This fix is only a temporary solution for german wikis.
Comment 12 Jeroen De Dauw 2010-03-17 23:40:56 UTC
Fixed in 0.5.4

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links