Last modified: 2010-01-19 15:47:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24147, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 22147 - Hook efContributorsAddonSetup failed to return a value
Hook efContributorsAddonSetup failed to return a value
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
Other All
: Normal blocker (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-01-19 07:57 UTC by Bertrand GRONDIN
Modified: 2010-01-19 15:47 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
screenshot of mediawiki interface (181.51 KB, image/png)
2010-01-19 07:57 UTC, Bertrand GRONDIN
Details

Description Bertrand GRONDIN 2010-01-19 07:57:15 UTC
Created attachment 6969 [details]
screenshot of mediawiki interface

Impossible to access to any page. I read the following messages :

In the header of the page : 

Warning: Parameter 2 to efContributorsAddonSetup() expected to be a reference, value given in /var/www/wiki/includes/Hooks.php on line 133


In the page : 

Detected bug in an extension! Hook efContributorsAddonSetup failed to return a value; should return true to continue hook processing or false to abort.

Backtrace:

#0 /var/www/wiki/includes/OutputPage.php(632): wfRunHooks('OutputPageParse...', Array)
#1 /var/www/wiki/includes/OutputPage.php(640): OutputPage->addParserOutputNoText(Object(ParserOutput))
#2 /var/www/wiki/includes/Article.php(3979): OutputPage->addParserOutput(Object(ParserOutput))
#3 /var/www/wiki/includes/Article.php(1321): Article->outputWikiText('<div style="fon...', false, Object(ParserOptions))
#4 [internal function]: Article->doViewParse()
#5 /var/www/wiki/includes/PoolCounter.php(59): call_user_func(Array)
#6 /var/www/wiki/includes/Article.php(908): PoolCounter_Stub->executeProtected(Array, false)
#7 /var/www/wiki/includes/Wiki.php(493): Article->view()
#8 /var/www/wiki/includes/Wiki.php(70): MediaWiki->performAction(Object(OutputPage), Object(Article), Object(Title), Object(User), Object(WebRequest))
#9 /var/www/wiki/index.php(117): MediaWiki->performRequestForTitle(Object(Title), Object(Article), Object(OutputPage), Object(User), Object(WebRequest))
#10 {main}
Comment 1 Bertrand GRONDIN 2010-01-19 08:19:33 UTC
The version of mediawiki is : r61244.
Comment 2 Sam Reed (reedy) 2010-01-19 13:07:09 UTC
Also, what extensions have you got installed?
Comment 3 Bawolff (Brian Wolff) 2010-01-19 13:23:07 UTC
This is probably for http://www.mediawiki.org/wiki/Extension:ContributorsAddon
as that is the extension with efContributorsAddonSetup() in it.
Comment 4 Sam Reed (reedy) 2010-01-19 13:32:30 UTC
Adding User:Tim Laqua as a CC

Though, it would look like the plugin is possibly out of date.

Last rev was r32289
Comment 5 Chad H. 2010-01-19 13:33:27 UTC
Curious. Can you confirm that in the copy you have installed, in the function efContributorsAddonSetup() in ContributorsAddon.php, the last line is 'return true;'. If not, what is the last bit, and does adding the return portion fix things?

If it does exist and is still failing, I'm curious as to how this relates to bug 21907. Maybe it's the 5.3.1 reference bug showing up?
Comment 6 Chad H. 2010-01-19 13:44:23 UTC
Fixed the warning about reference/value in r61246. This has been broken since the extension was written in r25146, $parseroutput was never passed by reference, since it was introduced in r16211.

This may (or may not) fix your issue with the exception being thrown. If it does, this was the underlying cause of that :)
Comment 7 Sam Reed (reedy) 2010-01-19 15:42:28 UTC
And if it does, please tell us ;)
Comment 8 Bertrand GRONDIN 2010-01-19 15:47:26 UTC
Php version 5.3.2 RC1 is compatible with mediawiki. Test successfull.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links