Last modified: 2010-01-08 21:01:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24051, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 22051 - Check return value of hook SpecialContributionsBeforeMainOutput in SpecialContributions
Check return value of hook SpecialContributionsBeforeMainOutput in SpecialCon...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.16.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-01-08 07:44 UTC by T. Gries
Modified: 2010-01-08 21:01 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Patch (485 bytes, patch)
2010-01-08 07:44 UTC, T. Gries 		Details
Add an attachment (proposed patch, testcase, etc.)

Description T. Gries 2010-01-08 07:44:04 UTC 
The return value of hook SpecialContributionsBeforeMainOutput in SpecialContributions is not checked. This means, that external users using this hook can currently not return a false value in order to abort the main processing (rendering the form and list of contribution).

I added an if() statement - see patch - in conformity to similar hooks in other modules.

With the patch, "false" stopps the processing.
Comment 1 T. Gries 2010-01-08 07:44:59 UTC 
Created attachment 6938 [details]
Patch
Comment 2 Alexandre Emsenhuber [IAlex] 2010-01-08 21:01:46 UTC 
Fixed in r60848.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links