Last modified: 2010-01-14 16:40:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24034, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 22034 - Use wfClientAcceptsGzip() in wfGzipHandler
Use wfClientAcceptsGzip() in wfGzipHandler
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.16.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-01-06 18:35 UTC by Platonides
Modified: 2010-01-14 16:40 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Use wfClientAcceptsGzip() in wfGzipHandler (1.51 KB, patch)
2010-01-06 18:35 UTC, Platonides 		Details
Second version of the patch (1.06 KB, patch)
2010-01-09 19:19 UTC, Platonides 		Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description Platonides 2010-01-06 18:35:23 UTC 
Created attachment 6929 [details]
Use wfClientAcceptsGzip() in wfGzipHandler

wfGzipHandler should use wfClientAcceptsGzip() instead of reimplement it itself.
Attached patch does it, and removes the $wgUseGzip check on wfClientAcceptsGzip() since HTMLFileCache (the only wfClientAcceptsGzip() user) already checked that before calling it. This way $wgUseGzip stays applying only for file cache, and $wgDisableOutputCompression for output handler.
Comment 1 Siebrand Mazeland 2010-01-09 18:10:50 UTC 
Applied in r60864. Thanks.
Comment 2 Siebrand Mazeland 2010-01-09 19:15:33 UTC 
Reverted in r60871. Causes PHP Notice: Undefined index: HTTP_ACCEPT_ENCODING in GlobalFunctions.php on line 1175
Comment 3 Platonides 2010-01-09 19:19:43 UTC 
Created attachment 6943 [details]
Second version of the patch
Comment 4 Platonides 2010-01-14 16:40:32 UTC 
Applied on r61054.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links