Last modified: 2010-02-03 23:32:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24032, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 22032 - API: fix for change tag queries
API: fix for change tag queries
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Roan Kattouw
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-01-06 13:05 UTC by Gurch
Modified: 2010-02-03 23:32 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
patch against r61457 (5.22 KB, patch)
2010-01-24 10:40 UTC, Gurch 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Gurch 2010-01-06 13:05:19 UTC 
Per http://www.mediawiki.org/wiki/Special:Code/MediaWiki/58399#c4958 there is a problem with the change tagging queries introduced in r58399.

"This omits the FORCE INDEX on the change_tag table when tag filtering is being done (i.e. with rctag=foo). Without this index, there's a chance this module will crash the site, like the UI version did before r49068. Presumably rvtag and letag are also affected, but I haven't tested them."

Obviously I don't want code I wrote to crash the site, but I'm not 100% sure how to fix this.
Comment 1 Gurch 2010-01-24 10:40:17 UTC 
Created attachment 7010 [details]
patch against r61457

Attached patch should fix this; specifies the appropriate index for recentchanges, revisions, usercontribs and logevents queries, also fixes an unrelated PHP notice in usercontribs.

Only thing I'm not sure about is on CodeReview for r58399 Roan claims the index has a different name on Wikimedia wikis, in which case this won't work; is that still the case?
Comment 2 Sam Reed (reedy) 2010-02-03 23:32:39 UTC 
r61957
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links