Last modified: 2010-01-05 17:09:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24017, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 22017 - Garbled class in content_wrapper div
Garbled class in content_wrapper div
Status: RESOLVED FIXED
Product: Wikimedia Mobile
Classification: Unclassified
Retired (Ruby) Gateway (Other open bugs)
.5
All All
: Normal minor (vote)
: ---
Assigned To: Hampton Catlin
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-01-05 11:31 UTC by Andrea Di Menna
Modified: 2010-01-05 17:09 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Andrea Di Menna 2010-01-05 11:31:07 UTC 
The div with id "content_wrapper" has a wrong class attribute.

E.g. english wiki

   <div class='["home", {"main_page"=&gt;"Main_Page", "selectors"=&gt;{"featured_article"=&gt;"#mp-tfa", "news_items"=&gt;"#mp-itn", "on_this_day"=&gt;"#mp-otd", "featured_picture"=&gt;"#mp-tfp", "facts"=&gt;"#mp-dyk"}}]' id='content_wrapper'> 

italian wiki

    <div class='["show", {"mobile_main_page"=&gt;"Pagina_Principale_%28mobile%29"}]' id='content_wrapper'> 

french wiki

    <div class='["home", {"main_page"=&gt;"Accueil", "selectors"=&gt;{"featured_article"=&gt;"#accueil-lumieresur", "news_items"=&gt;"#accueil-actualite", "facts"=&gt;"#SaviezVous", "featured_picture"=&gt;"#ImageDuJour"}}]' id='content_wrapper'> 

swedish wiki

    <div class='["home", {"mobile_main_page"=&gt;"Portal:Huvudsida_%28mobil%29"}]' id='content_wrapper'>
Comment 1 Derk-Jan Hartman 2010-01-05 15:40:52 UTC 
Caused by changeset http://github.com/hcatlin/wikimedia-mobile/commit/43a732c3dedcee2072461dc51827365ee8af1f32 on  app/views/layout/application.html.haml

I'm not sure of the intent of this change, so I don't feel comfortable fixing it.
Comment 2 Andrea Di Menna 2010-01-05 16:00:23 UTC 
Don't know either.
But this is causing some CSS rules to fail, e.g. :

#content_wrapper.home h1#firstHeading {
  display: none; }

And this is why it.m.wikipedia.org/wiki/::Home is showing an ugly "Prima_Pagina_(mobile)" (as well as sv.m.wikipedia.org/wiki/::Home.

Hampton, can you revert or fix it?
Comment 3 Hampton Catlin 2010-01-05 17:09:05 UTC 
Closed with a89d287f1f0fae9c4780921953d56b2a66d222e4

This was just a standard fuck-up bug.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links