Last modified: 2010-01-22 17:57:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T24012, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 22012 - ImportFreeImages incompatible with 1.16
ImportFreeImages incompatible with 1.16
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ImportFreeImages (Other open bugs)
unspecified
All All
: Normal major with 1 vote (vote)
: ---
Assigned To: Bryan Tong Minh
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-01-04 16:42 UTC by DaSch
Modified: 2010-01-22 17:57 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description DaSch 2010-01-04 16:42:31 UTC
The extension is broken with MW-1.16 when trying to import an image I get this error

Fatal error: Cannot use object of type WebRequest as array in /.../httpdocs/includes/specials/SpecialUpload.php on line 709
Comment 1 DaSch 2010-01-04 17:07:14 UTC
Well I search a bit in the code and discovered that UploadForm from SpecialUpload.php is called with wgRequest in ImportFreeImages.body.php in line 312

 $u = new UploadForm($wgRequest);

but in SpecialUpload.php there is an array with options wanted from line 694

class UploadForm extends HTMLForm {
	protected $mWatch;
	protected $mForReUpload;
	protected $mSessionKey;
	protected $mHideIgnoreWarning;
	protected $mDestWarningAck;
	
	protected $mTextTop;
	protected $mTextAfterSummary;
	
	protected $mSourceIds;

	public function __construct( $options = array() ) {
...
Comment 2 Roan Kattouw 2010-01-04 18:00:27 UTC
(In reply to comment #1)
> Well I search a bit in the code and discovered that UploadForm from
> SpecialUpload.php is called with wgRequest in ImportFreeImages.body.php in line
> 312
> 
>  $u = new UploadForm($wgRequest);
> 
> but in SpecialUpload.php there is an array with options wanted from line 694
>         public function __construct( $options = array() ) {
> ...
> 
Try $wgRequest->getValues(), that may work.
Comment 3 DaSch 2010-01-04 18:28:50 UTC
well that's not enough, there are severel other functions from SpecialUpload that where removed and where used by ImportFreeImages
Comment 4 Bryan Tong Minh 2010-01-04 18:31:27 UTC
The upload code was rewritten in 1.16, which unfortunately means that ImportFreeImages is incompatible with it.
Comment 5 DaSch 2010-01-04 18:37:55 UTC
Well that is what this bug is about

After changing $wgRequest to $wgRequest->getValues() another error occures

Fatal error: Call to undefined method UploadForm::execute() in /.../httpdocs/extensions/ImportFreeImages/ImportFreeImages.body.php on line 348
Comment 6 DaSch 2010-01-08 14:04:56 UTC
Can anybody provide a solution for this problem? I already wrote a mail to the developer but I didn't get an answer. I saw that wikia is using this extension and thought that it will be maintained well. Is there any chance to get this extension to work with MW 1.16?
Comment 7 DaSch 2010-01-11 15:59:41 UTC
anybody working on this or having the purpose to work on this?
Comment 8 Bryan Tong Minh 2010-01-12 13:43:54 UTC
Looks like an interesting project, I might take it in the future.
Comment 9 Travis D 2010-01-22 17:57:36 UTC
Fixed with revision 61372. 

Thanks.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links