Last modified: 2014-01-03 16:05:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T23984, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 21984 - Wikilinks containing dollar sign $ are not linked on Wikimedia Bugzilla
Wikilinks containing dollar sign $ are not linked on Wikimedia Bugzilla
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Bugzilla (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
https://bugzilla.wikimedia.org/show_b...
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-01-01 09:42 UTC by Liangent
Modified: 2014-01-03 16:05 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Comment 1 Liangent 2010-01-01 09:54:32 UTC 
Also in bug 21985. That dollar sign seems to be the problem.
Comment 2 Mark A. Hershberger 2011-05-14 23:33:04 UTC 
[[mw:Manual:$wgForeignFileRepos]] and [[Manual:$wgForeignFileRepos]] and [[mw:$wgForeignFileRepos]] are all tests.
Comment 3 Mark A. Hershberger 2011-05-14 23:34:13 UTC 
[[mw:Manual:wgForeignFileRepos]]
Comment 4 Bawolff (Brian Wolff) 2011-05-14 23:40:33 UTC 
In theory, r86427 was supposed to fix this. Did it ever get deployed?


(Well someone is doing this, it'd be awesome if someone could denote mw as an internal interwiki prefix, so such links actually work... There really is no reason not to have it as an internal prefix. But thats another bug somewhere)
Comment 5 Mark A. Hershberger 2011-05-14 23:59:09 UTC 
yeah, doesn't look like it was deployed.  Priyanka, if you haven't deployed, please do.
Comment 7 Krinkle 2011-05-15 00:39:06 UTC 
(In reply to comment #4)
> In theory, r86427 was supposed to fix this. Did it ever get deployed?
> 

r86427 fixed [[%]] (bug 5268), but not [[$]] (this bug).
Comment 8 Mark A. Hershberger 2011-05-15 01:11:21 UTC 
Looks like [[%]] was there before r86427, though.  Looking at the diff and these two bugs, I'm confused about what fixes what.
Comment 9 Bawolff (Brian Wolff) 2011-05-15 17:30:29 UTC 
(In reply to comment #7)
> (In reply to comment #4)
> > In theory, r86427 was supposed to fix this. Did it ever get deployed?
> > 
> 
> r86427 fixed [[%]] (bug 5268), but not [[$]] (this bug).

That bug isn't fixed. The bug was requesting that a lone % be url encoded into %25 instead of just being a raw % (and if you look at the url, [[%]] is still an invalid url). %'s were always linked as far as I can tell. (However with that said, I'm also unclear how r86427 has anything to do with that issue)
Comment 10 Priyanka Dhanda 2011-06-21 18:18:04 UTC 
Bugmeister is the new Bugzilla maintainer and default assignee.
Comment 11 Thehelpfulone 2012-06-22 19:21:46 UTC 
Reset assignee per bug 37789
Comment 12 Andre Klapper 2013-09-06 16:34:15 UTC 
I'm confused - URLs in bug 21985 link correctly nowadays. Plus comment 9 is about % but the bug summary is about $.

Could somebody provide a testcase, expected outcome, and describe current outcome?
Comment 13 Bawolff (Brian Wolff) 2013-09-06 16:55:52 UTC 
(In reply to comment #12)
> I'm confused - URLs in bug 21985 link correctly nowadays. Plus comment 9 is
> about % but the bug summary is about $.
> 
> Could somebody provide a testcase, expected outcome, and describe current
> outcome?

Presumably fixed. Comments are rendered at view time, once the bug is fixed, all old examples in comments are also fixed.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links