Last modified: 2009-12-21 03:22:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T23839, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 21839 - Wrong type of sighting on page history
Wrong type of sighting on page history
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Aaron Schulz
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-12-13 22:18 UTC by Leinad
Modified: 2009-12-21 03:22 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Leinad 2009-12-13 22:18:37 UTC
After rollbacking outdated reviewed page with no changes, in page history last edition is marked as "[sighted by XXX]", but there should be "[automatically sighted]".

To reproduce this bug:
1. Make edition as IP-user.
2. Again edit page as IP-user - remove changes in the previous edition and save page (in difference between revisions it should look like http://tools.wikimedia.pl/testwiki/w/index.php?title=Aster_(sie%C4%87_telefonii_kom%C3%B3rkowej)&action=historysubmit&diff=1436&oldid=864)
3. Log in as user with editor and rollback permission.
4. On history page click "rollback".
5. Look again at history page - last revision will be marked as sighted with message "[sighted by XXX]", but correct message should be "[automatically sighted]" (http://tools.wikimedia.pl/testwiki/w/index.php?title=Aster_(sie%C4%87_telefonii_kom%C3%B3rkowej)&action=history&uselang=en).
Comment 1 Aaron Schulz 2009-12-21 02:36:25 UTC
The problem is that null rollbacks don't leave an edit, so it's not clear why the edit was "automatically sighted". Using that message makes it seem like then edit was sighted at the time the anon made it.

"automatically sighted" is more internally consistent though.
Comment 2 Aaron Schulz 2009-12-21 03:22:04 UTC
Changed in r60249.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links