Last modified: 2011-01-25 00:57:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T23814, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 21814 - Rollback claims to have reverted revision deletion
Rollback claims to have reverted revision deletion
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Revision deletion (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Aaron Schulz
http://en.wikipedia.org/w/index.php?t...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-12-10 20:30 UTC by MBisanz
Modified: 2011-01-25 00:57 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of above link. (159.06 KB, image/png)
2009-12-10 20:30 UTC, MBisanz
Details

Description MBisanz 2009-12-10 20:30:36 UTC
Created attachment 6868 [details]
Screenshot of above link.

Using the (rollback) links in page history and the watchlist, I was able to successfully revert an edit that was hidden with revision deletion, even though I couldn't see the edit and the revert did not appear in my edit history.
Comment 1 MZMcBride 2009-12-10 20:59:58 UTC
To be clear, this is only an issue of poor error reporting. The rollback _says_ it is successful, but it doesn't actually revert the edits.

The correct behavior is displaying a message to the user that the rollback failed.
Comment 2 Aaron Schulz 2009-12-10 21:11:49 UTC
Can't repro locally
Comment 3 Alex Z. 2009-12-15 07:06:43 UTC
I can reproduce this on my local copy. 

(In reply to comment #0)
> Using the (rollback) links in page history and the watchlist, I was able to
> successfully revert an edit that was hidden with revision deletion, even though
> I couldn't see the edit and the revert did not appear in my edit history.
> 

You could revert it because the content of the edits you were reverting to and from were not deleted, so you could still see the diff between them (just not the diffs involving the intervening edit). In the later edit, only the username was suppressed.

(In reply to comment #1)
> To be clear, this is only an issue of poor error reporting. The rollback _says_
> it is successful, but it doesn't actually revert the edits.
> 
> The correct behavior is displaying a message to the user that the rollback
> failed.
> 

The rollback does actually work, in the case given it didn't show up in the page history as the rollback would have been a null edit.


Comment 4 Alex Z. 2009-12-15 07:27:09 UTC
Fixed in r60064

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links