Last modified: 2010-01-16 19:06:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T23683, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 21683 - list=search doesn't provide offset for continuation if over the account group maximum
list=search doesn't provide offset for continuation if over the account group...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-11-29 23:20 UTC by Sam Reed (reedy)
Modified: 2010-01-16 19:06 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2009-11-29 23:20:31 UTC
Not quite sure if this is really an API bug, or a search bug.. Or what... Or whether its a WMF/Lucene implimented limitation.

If you use srlimit=max, or anything above (No more than 50 (500 for bots) allowed.), no offset is given for continuing. Using anything below, does

If this is enforced behaviour (due to WMF, Lucene, or similar), the API documentation should be updated to this effect (ie the help the API provides).



<limits search="500" /> also sporadicly appears. What is that?
Comment 1 Roan Kattouw 2009-11-30 12:13:13 UTC
(In reply to comment #0)
> Not quite sure if this is really an API bug, or a search bug.. Or what... Or
> whether its a WMF/Lucene implimented limitation.
> 
> If you use srlimit=max, or anything above (No more than 50 (500 for bots)
> allowed.), no offset is given for continuing. Using anything below, does
> 
Are you sure there *is* anything to continue? Try srlimit=30 (300 if you're a bot) and continuing once to find out.

> If this is enforced behaviour (due to WMF, Lucene, or similar), the API
> documentation should be updated to this effect (ie the help the API provides).
> 
Not sure what causes this yet, will investigate.

> <limits search="500" /> also sporadicly appears. What is that?
> 
That shows up when using srlimit=max . It's the API's way of telling you what it translated "max" to.
Comment 2 Robert Stojnic 2009-11-30 12:19:58 UTC
I've put the maximum on the backend to 50 in order to prevent overloads. Will be enforced at least until new servers get it.
Comment 3 Sam Reed (reedy) 2009-11-30 14:00:17 UTC
Roan, searching for "test" will most certainly find more than 50..

http://en.wikipedia.org/w/api.php?action=query&list=search&srwhat=text&srsearch=all:'test'&srlimit=max

<searchinfo totalhits="2443730" />

Robert, thanks for this information. Presumably why its showing a larger result set, than the full 500 it's supposed to be returning (what the api is reporting).

IMHO then, its not really a bug, or at least, less of (changing to enhancement), we just could ideally do with a comment (really only on the wmf version.. Unless with the lucene search extension we can grab check a variable to find the limits that are being imposed)
Comment 4 Sam Reed (reedy) 2010-01-11 13:08:04 UTC
Haven't the search limits been increased again...?
Comment 5 Roan Kattouw 2010-01-11 13:11:40 UTC
(In reply to comment #4)
> Haven't the search limits been increased again...?
> 

Yes, the backend limit has been increased again. Per Robert the API limit is still at 50, which means that at least normal operation with srlimit < 50 should work again. Setting srlimit equal to 500 is probably still broken (please test this); if it is, I'll ask Robert to raise the limit to 501 as a workaround.
Comment 6 Sam Reed (reedy) 2010-01-16 18:52:59 UTC
Ok, as a sysop (against en.wp), max gives 500.

Setting the limit to 500 gives 499.

So presumably, if we can get this change to 501 on the search end, this can be marked as fixed/resolved.
Comment 7 Robert Stojnic 2010-01-16 18:59:44 UTC
The max on the backend is 501 for more than a week now.
Comment 8 Sam Reed (reedy) 2010-01-16 19:06:21 UTC
Seems I must've miscopied. Just checked and it is.

Marking as fixed. Thanks!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links