Wikimedia Bugzilla is closed!

It did work for sure - I wonder when it stopped working.

Tried on another site and also different OpenIDs and it is not redirecting to the requested URL.
How is it supposed to work, is the requested stored locally during login?

Yes, I believe so.

I noticed that it works on TechPresentations.org but doesn't work on MediaWikiWidgets.org - will try to investigate.

Hmm. Interesting... it seems to work now. Looks like a hard bug to catch.

I have the problem consistently, you can test using my test site here http://tricky.dragonspell.com/tricky/, I currently have it setup so you have to login to view anything, just thought are there any other pages I need to make public i.e. $wgWhitelistRead = array ('Special:OpenIDLogin','Special:OpenIDFinish'); .

Here is a direct link to a page http://tricky.dragonspell.com/tricky/index.php/Setting_up_PHP_OpenID_with_MediaWiki_%26_Google_Apps

Actually, it worked just fine with my Google-powered OpenID.

I went to this page: http://tricky.dragonspell.com/tricky/index.php/Tricky:Community_Portal while being logged out.

Then I clicked on "Login with OpenID" link at the top right (which has Google icon for some reason) and it sent me to http://tricky.dragonspell.com/tricky/index.php?title=Special:OpenIDLogin&returnto=Tricky:Community_Portal - notice the returnto parameter.

Then I used Google account to log in and created an account on your wiki and then it brought me to the page that said "you're logged in, please return to Tricky:Community_Portal" with appropriate link.

It keeps me wonder if it depends on OpenID provider as well - will try to do more testing.

Works for me too using the OpenID link rather than the "You must log in to view other pages." link 

Trying on our live site, I notice that they are different.

http://mywiki.symbian.org/w/index.php?title=Special:OpenIDLogin&returnto=Symbian_Handbook  - Works

http://mywiki.symbian.org/w/index.php?title=Special:UserLogin&returnto=Symbian_Handbook  - Fails

So by the looks of it we need to change that link provided when the user needs to login to http://mywiki.symbian.org/w/index.php?title=Special:OpenIDLogin

UserLogin is not an OpenID login. If you click there, what do you do next to log in?

It takes you to the Special:OpenIDLogin page but without the &returnto parameter details, so the linked to page is lost.

I should note we have $wgOpenIDOnly = yes, so I think the problem is in this hook (OpenID.hooks.php:8 or so)

                if ( $wgOpenIDOnly ) {
                        $list['Userlogin'] = array( 'SpecialRedirectToSpecial', 'Userlogin', 'OpenIDLogin' );

A call to http://example.org/w/index.php/Special:Userlogin?foo=bar&pie=nice gets rewritten to http://example.org/w/index.php/Special:OpenIDLogin with no query parameters.

Created attachment 6861 [details]
Patch for Bug 21661.

Patch attached to fix issue.

Yes, this seems to be true for $wgOpenIDOnly where returnto gets dropped on that redirect.
I'll apply your patch.

The question is - is it getting dropped somewhere else as well, beacuse I saw the issue, but just have hard time catching it (even without using $wgOpenIDOnly).

OK, looks like I was able to nail it down to the session - if you just start the browser, then returnto gets dropped somewhere in the chain on first OpenID login, then on consequent OpenID logins it works fine.

"returntoquery" parameter added in r60239.

Created attachment 7308 [details]
Fix for problem with redirect (only on first attempt to log in)

Finally got bothered enough to sit down with this one today.

The problem, as Sergei alluded to, is that you are storing information on the session before the session is initialized as far as MW is concerned.  Adding a startSession() before saving the return page onto the session fixes the problem - one-line patch attached.

Perfect, it nailed it!

Applied in r65395.