Last modified: 2013-06-18 15:28:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T23660, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 21660 - Support full-width commas for pipe trick
Support full-width commas for pipe trick
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.16.x
All All
: Normal normal (vote)
: ---
Assigned To: Tim Starling
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-11-27 14:24 UTC by Liangent
Modified: 2013-06-18 15:28 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
full-width commas (1004 bytes, patch)
2009-11-27 14:24 UTC, Liangent 		Details
Do it without adding another regex. Also includes parser tests. (2.08 KB, patch)
2011-11-27 01:13 UTC, Dan Collins 		Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description Liangent 2009-11-27 14:24:52 UTC 
Created attachment 6827 [details]
full-width commas

It doesn't support full-width commas.
Comment 1 Siebrand Mazeland 2010-01-09 18:25:19 UTC 
Tim, please review.
Comment 2 Conrad Irwin 2010-02-07 02:18:55 UTC 
Fixed in r62076
Comment 3 Raimond Spekking 2010-02-19 11:46:58 UTC 
Reverted by Tim in r62689. Work branched to http://www.mediawiki.org/w/index.php?title=Special:Code/MediaWiki/path&path=%2Fbranches%2Fconrad
Comment 4 Dan Collins 2011-11-27 01:13:34 UTC 
Created attachment 9566 [details]
Do it without adding another regex. Also includes parser tests.

I don't see any reason why we can't fix this just like bug 30149. I add some parser tests as well (which pass) and fix a problem with one of the parser tests I wrote for 30149 (there were some spaces that shouldn't have been, it still passed but some possibilities weren't covered).
Comment 5 Dan Collins 2012-05-23 19:44:23 UTC 
See Gerrit change #8696
Comment 6 Rob Lanphier 2012-07-04 00:36:51 UTC 
That change was deployed, so marking resolved.  Please reopen if you test and find a problem.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links