Last modified: 2009-11-26 20:20:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T23650, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 21650 - Incompatible calls to SkinTemplateTabs hook
Incompatible calls to SkinTemplateTabs hook
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.16.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-11-26 19:47 UTC by Juliano F. Ravasi
Modified: 2009-11-26 20:20 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Juliano F. Ravasi 2009-11-26 19:47:52 UTC 
Skin::extensionTabLinks() in Skin.php calls:

    wfRunHooks( 'SkinTemplateTabs', array( $this, &$tabs ) );


SkinTemplate::buildContentActionUrls() in SkinTemplate.php calls:

    wfRunHooks( 'SkinTemplateTabs', array( &$this, &$content_actions ) );


Note the presence of & reference operator applied on $this in the SkinTemplate call. Both calls should be compatible. Probably the first one is correct, according to the documentation in http://www.mediawiki.org/wiki/Manual:Hooks/SkinTemplateTabs .
Comment 1 Alexandre Emsenhuber [IAlex] 2009-11-26 20:20:13 UTC 
Fixed in r59468.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links