Last modified: 2013-06-18 14:41:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 21590 - Comments about variables depending on $wgScriptPath are confusing or wrong
Comments about variables depending on $wgScriptPath are confusing or wrong
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Documentation (Other open bugs)
unspecified
All All
: Low trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-11-22 07:24 UTC by Ichiro
Modified: 2013-06-18 14:41 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Proposed patch, in accordance with discussion on mediawiki-l (2.94 KB, patch)
2009-11-22 07:50 UTC, Ichiro
Details
Proposed patch, this time in unified format (4.38 KB, patch)
2009-11-22 11:18 UTC, Ichiro
Details
Re-based patch against trunk (3.86 KB, patch)
2011-11-09 11:59 UTC, Chad H.
Details

Comment 1 Ichiro 2009-11-22 07:50:30 UTC
Created attachment 6812 [details]
Proposed patch, in accordance with discussion on mediawiki-l
Comment 2 Roan Kattouw 2009-11-22 09:37:31 UTC
Please attach a patch in unified diff format.
Comment 3 Ichiro 2009-11-22 11:18:29 UTC
Created attachment 6813 [details]
Proposed patch, this time in unified format
Comment 4 Chad H. 2009-11-28 13:39:37 UTC
Tweaked summary to be more specific.

Also: not really liking that patch. All you're adding is "in Setup.php" to all of the comments. While it does clarify the situation to some degree, it's still not massively helpful--most people don't know our setup order and saying "in Setup.php" is meaningless to them.
Comment 5 Ichiro 2009-12-01 12:47:42 UTC
I respectfully revert the summary, since some parts are actually wrong.
Please following the links in the description for all the details.

>  All you're adding is "in Setup.php" to all of the comments.

This is incorrect, please look more carefully.
Comment 6 Ichiro 2009-12-28 06:46:51 UTC
Hello - any reason why this has not been integrated yet? Thanks.
Comment 7 p858snake 2011-04-30 00:09:52 UTC
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Comment 8 Sumana Harihareswara 2011-11-09 04:11:34 UTC
Ichiro, I'm sorry to say that your patch no longer applies against Subversion trunk (I am thus marking it reviewed).  Would you be interested in coming into #mediawiki on FreeNode IRC and discussing the problem and coming up with an approach for a new patch?  Thanks!
Comment 9 Chad H. 2011-11-09 11:59:35 UTC
Created attachment 9398 [details]
Re-based patch against trunk

I went ahead and re-based the patch against trunk, it took about a minute :)
Comment 10 Chad H. 2011-11-09 17:04:03 UTC
Went ahead and committed (albeit by accident) in r102532.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links