Last modified: 2013-06-18 16:29:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T23559, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 21559 - wrap stand alone message 'logempty'
wrap stand alone message 'logempty'
Status: RESOLVED DUPLICATE of bug 24511
Product: MediaWiki
Classification: Unclassified
Page protection (Other open bugs)
unspecified
All All
: Low enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
http://de.wikipedia.org/w/index.php?t...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-11-18 18:28 UTC by Umherirrender
Modified: 2013-06-18 16:29 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
page from url in edit mode (skin vector) (25.96 KB, image/png)
2009-11-20 16:48 UTC, Umherirrender
Details

Description Umherirrender 2009-11-18 18:28:01 UTC
When there is a semiprotected page, and MediaWiki found no log entry for the page the message 'logempty' is used. But the message stand there without any informationen. See url for example.

Please wrap 'logempty' always in a warning message, in this case it that message 'semiprotectedpagewarning', because 'logempty' as a stand alone message is confused. Thanks.
Comment 1 Umherirrender 2009-11-20 16:48:07 UTC
Created attachment 6807 [details]
page from url in edit mode (skin vector)

pic to show, which text I mean.
Comment 2 Alexandre Emsenhuber [IAlex] 2009-12-04 18:38:55 UTC
Fixed in r59740.
Comment 3 Umherirrender 2009-12-06 20:07:45 UTC
That was not my request.

The message 'logempty' is stand alone without any other message and so the user does not know for which log there were no matching items found. That is very useless and confuse.
Comment 4 Maarten Dammers 2010-08-08 17:11:34 UTC
I came across this bug at http://nl.wikipedia.org/wiki/Sjabloon:Infobox/breedte.

This page was protected before the protection log existed.

The relevant code from http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/EditPage.php?view=markup

1438 	 if ( $this->mTitle->getNamespace() != NS_MEDIAWIKI && $this->mTitle->isProtected( 'edit' ) ) {
1439 	# Is the title semi-protected?
1440 	if ( $this->mTitle->isSemiProtected() ) {
1441 	$noticeMsg = 'semiprotectedpagewarning';
1442 	} else {
1443 	# Then it must be protected based on static groups (regular)
1444 	$noticeMsg = 'protectedpagewarning';
1445 	}
1446 	LogEventsList::showLogExtract( $wgOut, 'protect', $this->mTitle->getPrefixedText(), '',
1447 	array( 'lim' => 1, 'msgKey' => array( $noticeMsg ) ) ); 

Here LogEventsList::showLogExtract is used to produce the message. This code is in http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/LogEventsList.php?&view=markup

LogEventsList::showLogExtract will return the message 'Logempty' ("No matching items in log.") when no matching items are found in the log.

'showIfEmpty' should probably set to False and a test should be added to see if the number of returned items is 1 and if not, $noticeMsg should be added to the output.
Comment 5 Nemo 2012-07-26 19:51:52 UTC

*** This bug has been marked as a duplicate of bug 24511 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links