Last modified: 2010-01-21 22:46:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T23459, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 21459 - WikiEditor does not show if TOC is set to false as of r58851
WikiEditor does not show if TOC is set to false as of r58851
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UsabilityInitiative (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-11-09 23:13 UTC by Jools Wills
Modified: 2010-01-21 22:46 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jools Wills 2009-11-09 23:13:00 UTC
Not sure if svn is supposed to be kept "in a working state", so sorry if this bug report is something known and planned to be fixed.

I updated to the latest SVN HEAD version of the extension today (r58851). I changed the configuration to match the new array system (Still undocumented but I assume this is on your todo list). However, the toolbar didn't appear.

Seems that I have to enable the table of contents, or the wikieditor doesn't appear.

doesnt work:
$wgWikiEditorModules = array(
	'toc' => array( 'global' => false, 'user' => false ),
	'toolbar' => array( 'global' => true, 'user' => false ),
);

works:
$wgWikiEditorModules = array(
	'toc' => array( 'global' => true, 'user' => false ),
	'toolbar' => array( 'global' => true, 'user' => false ),
);
Comment 1 Roan Kattouw 2009-11-10 10:09:51 UTC
(In reply to comment #0)
> Not sure if svn is supposed to be kept "in a working state", so sorry if this
> bug report is something known and planned to be fixed.
> 
Yes, SVN HEAD is pretty broken at the moment, we expect this to be better around the end of the week.

> I updated to the latest SVN HEAD version of the extension today (r58851). I
> changed the configuration to match the new array system (Still undocumented but
> I assume this is on your todo list).
Yes, sorry about thiat.

> However, the toolbar didn't appear.
> 
> Seems that I have to enable the table of contents, or the wikieditor doesn't
> appear.
> 
> doesnt work:
> $wgWikiEditorModules = array(
>         'toc' => array( 'global' => false, 'user' => false ),
>         'toolbar' => array( 'global' => true, 'user' => false ),
> );
> 
> works:
> $wgWikiEditorModules = array(
>         'toc' => array( 'global' => true, 'user' => false ),
>         'toolbar' => array( 'global' => true, 'user' => false ),
> );
> 
Interesting. I'll debug this, but it may have to wait for a bit while we're restructuring other parts.
Comment 2 Roan Kattouw 2009-11-13 00:02:57 UTC
Fixed in r58991 and r58992.
Comment 3 Jools Wills 2009-11-13 00:07:54 UTC
Sorry to report but this is still not working for me.

I just updated the extension to r58992, with the following config

require_once("extensions/UsabilityInitiative/WikiEditor/WikiEditor.php");
$wgWikiEditorModules = array(
	'toc' => array( 'global' => true, 'user' => false ),
	'toolbar' => array( 'global' => true, 'user' => false ),
);

I am getting no new editor at all. Also in my user prefs I get the options

 	 Enable navigable table of contents
 	 Enable enhanced editing toolbar
 	 Enable dialogs for inserting links, tables and more

but surely I should get no preferences at all with my config above?

My Mediawiki version is r58824.
Comment 4 DGennaro 2009-11-18 15:34:36 UTC
This is still not working for me either. I have just updated the extension to r59186.
Comment 5 Roan Kattouw 2009-12-23 15:05:56 UTC
Fixed in r60316 and r60317. Note that the "Enable dialogs for inserting links, tables and more" will still be shown if the toolbar is globally enabled.
Comment 6 DGennaro 2009-12-28 21:21:10 UTC
The WikiEditor is still not working for me in r60451.
Comment 7 Roan Kattouw 2009-12-28 21:22:15 UTC
(In reply to comment #6)
> The WikiEditor is still not working for me in r60451.
> 

Not working how?
Comment 8 DGennaro 2009-12-29 14:37:31 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > The WikiEditor is still not working for me in r60451.
> > 
> Not working how?

The WikiEditor is not loading. Only the standard editing toolbar.

Comment 9 Roan Kattouw 2009-12-29 14:48:12 UTC
(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > The WikiEditor is still not working for me in r60451.
> > > 
> > Not working how?
> 
> The WikiEditor is not loading. Only the standard editing toolbar.
> 

Could you:
1) tell us what your $wgWikiEditorModules is set to (if set)
2) try commenting out your $wgWikiEditorModules (if set) and see if that fixes the problem
3) tell us whether you're logged in or not when viewing the edit form, and
3a) if logged in, tell us which checkboxes in My preferences -> Editing -> Experimental are checked
Comment 10 DGennaro 2009-12-29 15:09:40 UTC
(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > (In reply to comment #6)
> > > > The WikiEditor is still not working for me in r60451.
> > > > 
> > > Not working how?
> > 
> > The WikiEditor is not loading. Only the standard editing toolbar.
> > 
> Could you:
> 1) tell us what your $wgWikiEditorModules is set to (if set)
> 2) try commenting out your $wgWikiEditorModules (if set) and see if that fixes
> the problem
> 3) tell us whether you're logged in or not when viewing the edit form, and
> 3a) if logged in, tell us which checkboxes in My preferences -> Editing ->
> Experimental are checked

1)##default in WikiEditor.php##
$wgWikiEditorModules = array(
	'highlight' => array( 'global' => false, 'user' => true ),
	'preview' => array( 'global' => false, 'user' => true ),
	'publish' => array( 'global' => false, 'user' => true ),
	'toc' => array( 'global' => false, 'user' => true ),
	'toolbar' => array( 'global' => false, 'user' => true ),
	'templateEditor' => array( 'global' => false, 'user' => true ),
);
##I have also tried the settings noted above:##
$wgWikiEditorModules = array(
        'toc' => array( 'global' => true, 'user' => false ),
        'toolbar' => array( 'global' => true, 'user' => false ),
);

2) Still not working

3) Yes, I am logged in.

3a) My preferences -> Editing -> Experimental
"Enable enhanced editing toolbar"


I am receiving the following error on the page when editing:
Error: 'mw' is undefined

Hope this helps.
Comment 11 DGennaro 2009-12-29 15:15:14 UTC
In addition to above:

1 continued) I have also tried the settings noted in the README file:

$wgWikiEditorModules = array(
	'highlight' => array( 'global' => false, 'user' => true ),
	'preview' => array( 'global' => false, 'user' => true ),
	'toc' => array( 'global' => false, 'user' => true ),
	'toolbar' => array( 'global' => false, 'user' => true ),
);

Comment 12 Roan Kattouw 2009-12-29 18:00:43 UTC
(In reply to comment #10)
> I am receiving the following error on the page when editing:
> Error: 'mw' is undefined
> 
> Hope this helps.
> 
You need to update your version of MediaWiki. Every now and then we change stuff in MediaWiki core and update the UsabilityInitiative extension to rely on those changes.
Comment 13 Jools Wills 2009-12-29 18:01:56 UTC
Yeh it sounds like you are not running the latest version from svn of mediawiki. I had the same problem that the toolbar wasn't appearing at all, and a svn up quickly fixed it.
Comment 14 DGennaro 2010-01-14 16:59:21 UTC
I have upgraded to the latest version of MW 1.16alpha and the toolbar is showing now, but none of the buttons work [r61050].
Comment 15 DGennaro 2010-01-21 22:46:48 UTC
[r61338] no longer shows the toolbar.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links