Last modified: 2009-11-12 23:28:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T23434, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 21434 - README refers to non-existent directories
README refers to non-existent directories
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UsabilityInitiative (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-11-08 05:13 UTC by Victor Hooi
Modified: 2009-11-12 23:28 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Victor Hooi 2009-11-08 05:13:11 UTC
heya,

I just did a "svn update" on the UsabilityInitiative directory in my MediaWiki installation. I then attempted to run upgrade.php.

This promptly bombed out, and it was only here that I noticed that the lines I'd previously put in LocalSettings.php, as recommended by the UsabilityInitiative README now referred to non-existent directories.

I checked online, to see if perhaps my SVN checkout had broken (http://svn.wikimedia.org/svnroot/mediawiki/trunk/extensions/UsabilityInitiative/). However, same content there.

I checked the README file again, no updates to the lines given there, or updated paths.

Specifically, the lines 

#require_once( "$IP/extensions/UsabilityInitiative/SimpleSearch/SimpleSearch.php" );

require_once( "$IP/extensions/UsabilityInitiative/EditWarning/EditWarning.php" );

require_once( "$IP/extensions/UsabilityInitiative/EditToolbar/EditToolbar.php" );

require_once( "$IP/extensions/UsabilityInitiative/NavigableTOC/NavigableTOC.php" );

will all fail.

I'm not sure if this is part of a broader refactoring in the extension, and I just checked-out at a bad time, however, there is nothing in the README at all about this at all (If it is simply a documentation thing, then perhaps close this bug when the docs are fixed).

Cheers,
Victor
Comment 1 Victor Hooi 2009-11-08 05:16:32 UTC
heya,

Well, commenting out the above mentioned lines, and adding:

require_once( "$IP/extensions/UsabilityInitiative/WikiEditor/WikiEditor.php" );

works. Lol. So perhaps somebody update the README?

Cheers,
Victor
Comment 2 Roan Kattouw 2009-11-08 16:29:22 UTC
(In reply to comment #0)
> Specifically, the lines 
> 
> #require_once(
> "$IP/extensions/UsabilityInitiative/SimpleSearch/SimpleSearch.php" );
> 
> require_once( "$IP/extensions/UsabilityInitiative/EditWarning/EditWarning.php"
> );
> 
> require_once( "$IP/extensions/UsabilityInitiative/EditToolbar/EditToolbar.php"
> );
> 
> require_once(
> "$IP/extensions/UsabilityInitiative/NavigableTOC/NavigableTOC.php" );
> 
> will all fail.
> 
> I'm not sure if this is part of a broader refactoring in the extension, and I
> just checked-out at a bad time, however, there is nothing in the README at all
> about this at all (If it is simply a documentation thing, then perhaps close
> this bug when the docs are fixed).
> 
You're right, the extension was recently refactored. To make it work again, replace all require_once() lines you previously used with:

require_once("$IP/extensions/UsabilityInitiative/Vector/Vector.php"); // CollapsibleTabs, SimpleSearch, EditWarning
require_once("$IP/extensions/UsabilityInitiative/WikiEditor/WikiEditor.php"); // EditToolbar, NTOC, some new stuff

The way modules are enabled and disabled have also changed. I'm not gonna detail that here, but it will go into the updated README file.
Comment 3 Roan Kattouw 2009-11-12 23:28:29 UTC
Fixed in r58988.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links