Last modified: 2010-01-09 20:18:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 21411 - Add a new message rev-suppressed-no-diff for diff without entry in public log
Add a new message rev-suppressed-no-diff for diff without entry in public log
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Revision deletion (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Aaron Schulz
: easy, patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-11-04 17:29 UTC by merl
Modified: 2010-01-09 20:18 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description merl 2009-11-04 17:29:19 UTC
If a revision is deleted the diff always shows rev-deleted-no-diff for "normal" users which contains a link to Special:Log/delete. But if one revision is suppressed the log doesn't contains any information. So it would by nice to have a new message rev-suppressed-no-diff which doens't conatins a link to the deletion log.

Nessessary Code Changes in diff/DifferenceInterface.php:
-$wgOut->wrapWikiMsg( "<div class='mw-warning plainlinks'>\n$1</div>\n",
-			array( 'rev-deleted-no-diff' ) );
+$msg = $suppressed ? 'rev-suppressed-no-diff' : 'rev-deleted-no-diff';
+$wgOut->wrapWikiMsg( "<div class='mw-warning plainlinks'>\n$1</div>\n", array( $msg) );

System Message Changes:

rev-deleted-no-diff:
-You cannot view this diff because one of the revisions has been '''deleted'''.
-There may be details in the [{{fullurl:{{#Special:Log}}/delete|page={{FULLPAGENAMEE}}}} deletion log].
+You cannot view this diff because one of the revisions has been '''deleted'''.
+Details can be found in the [{{fullurl:{{#Special:Log}}/delete|page={{FULLPAGENAMEE}}}} deletion log].

rev-suppressed-no-diff:
+You cannot view this diff because one of the revisions has been '''removed from the public archives'''.
Comment 1 Aaron Schulz 2009-11-20 05:52:26 UTC
Currently suppression status not hinted at for non-admins anywhere to discourage xml dump searching.
Comment 2 Siebrand Mazeland 2010-01-09 18:41:03 UTC
Aaron, please bring this issue to a resolution. Thanks.
Comment 3 Aaron Schulz 2010-01-09 20:18:52 UTC
Done in r60876.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links