Last modified: 2009-11-01 13:59:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T23369, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 21369 - Lowercase logins causes MediaWiki to crash on CapitalLinks set to false
Lowercase logins causes MediaWiki to crash on CapitalLinks set to false
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User login and signup (Other open bugs)
1.16.x
All All
: Normal critical (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-10-31 23:25 UTC by Svip
Modified: 2009-11-01 13:59 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Svip 2009-10-31 23:25:06 UTC
Usernames start with a capital letter (in accordance with the regular MediaWiki scheme).  And MediaWiki should handle making the first letter a capital letter, even if the user tries to log in in entirely lowercase.

E.g. Logging in as 'svip' would change it to 'Svip'.

But for some reason, this does not accord if $wgCapitalLinks is set to false on the newest revision of MediaWiki.  Instead, such an attempt produces the following error:

Fatal error: Call to a member function getName() on a non-object /includes/specials/SpecialUserlogin.php on line 441

To avoid the error, simply logging in the correct case fixes the issue.  I assume this bug is trivial, but critical regardless.
Comment 1 Ryan Schmidt 2009-10-31 23:27:23 UTC
The fix would be to add NS_USER to the MWNamespace::alwaysCaptializedNamespaces array (in /includes/Namespace.php), but I do not know if there are any current users with lowercase names that would not be able to log in after this change, hence why I am mentioning it here instead of committing it.
Comment 2 Roan Kattouw 2009-11-01 09:29:06 UTC
(In reply to comment #1)
> but I do not know if there are any current
> users with lowercase names that would not be able to log in after this change,
> 

They're not able to log in now, either, and I don't think they ever were.
Comment 3 Chad H. 2009-11-01 13:59:11 UTC
Should be fixed with r58401

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links