Last modified: 2009-11-03 14:48:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T23319, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 21319 - Infinite recursion in Thread::loadAllData()
Infinite recursion in Thread::loadAllData()
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
LiquidThreads (Other open bugs)
unspecified
All All
: Normal blocker (vote)
: ---
Assigned To: Andrew Garrett
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-10-28 02:37 UTC by Tim Starling
Modified: 2009-11-03 14:48 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Tim Starling 2009-10-28 02:37:55 UTC 
Eugene reported on IRC that posting to LiquidThreads, e.g. using "reply", was totally broken and left the ajax spinner going forever. He indicated that this had been occurring since some time earlier today. 

Investigation showed that this was a segfault in api.php?action=threadaction&threadaction=reply&..., with a backtrace showing an infinite recursion of Thread::loadAllData(). A trivial call to loadAllData() from eval.php did not lead to infinite recursion, so it's likely that the problem only occurs after local data is updated.

I've rolled back the latest merge from trunk (r58164) pending a permanent fix.
Comment 1 Andrew Garrett 2009-11-03 14:48:07 UTC 
Fix committed in r58473 and deployed to WMF wikis.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links