Last modified: 2010-01-22 23:27:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T23226, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 21226 - Make Navigable TOC collapsible
Make Navigable TOC collapsible
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UsabilityInitiative (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Adam Miller
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-10-21 19:25 UTC by Thomas Bleher
Modified: 2010-01-22 23:27 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
NTOC and ProofreadPage on a netbook screen (152.07 KB, image/png)
2009-10-21 19:25 UTC, Thomas Bleher
Details

Description Thomas Bleher 2009-10-21 19:25:13 UTC
Created attachment 6698 [details]
NTOC and ProofreadPage on a netbook screen

When using the ProofreadPage extension together with the enhanced editing toolbar, the editing window gets very small. It would be nice if there was a button to collapse the Navigable TOC so the edit window becomes larger.

Attached is a screen shot of how this looks like on my netbook (This is r57791 of the UsabilityInitiative extension)
Comment 1 Roan Kattouw 2009-10-22 11:58:59 UTC
Seems you're reading our minds, we were already planning on doing this. Assigning to Adam since he's probably gonna be implementing this.
Comment 2 Roan Kattouw 2009-10-30 19:42:07 UTC
This feature is now live on the prototype wikis.
Comment 3 Thomas Bleher 2009-11-14 20:52:03 UTC
Hmm, doesn't seem to work on e.g. http://prototype.wikimedia.org/d-en/index.php?title=Taliban&action=edit .
I tested it on my local wiki, and by setting
  $wgNavigableTOCCollapseEnable = true;
in LocalSettings.php I got the button to appear, but it seems broken. When clicking it, the NTOC text disappears, but the edit area is not resized. The button also disappears, so there is no way to get the text back.

Tested with the following settings:
$wgDefaultUserOptions['skin'] = 'vector';
$wgDefaultUserOptions['usenavigabletoc'] = 1;
$wgDefaultUserOptions['wikieditor-highlight'] = 1;
$wgDefaultUserOptions['wikieditor-preview'] = 1;
$wgDefaultUserOptions['usebetatoolbar'] = 1;
$wgDefaultUserOptions['usebetatoolbar-cgd'] = 1;
$wgNavigableTOCCollapseEnable = true;
$wgVectorUseSimpleSearch = true;
$wgEnableJS2system = true;
// the following are old IIRC
$wgEditToolbarGlobalEnable = true;
$wgEditToolbarCGDGlobalEnable = true;
$wgNavigableTOCGlobalEnable = true;
$wgEditToolbarUserEnable = false;

phase3 r59072, UsabilityInitiative r59048 (i.e. from today)

Tested using Iceweasel 3.0.6 on Debian Lenny.
Comment 4 Roan Kattouw 2009-11-14 21:17:14 UTC
(In reply to comment #3)
> Hmm, doesn't seem to work on e.g.
> http://prototype.wikimedia.org/d-en/index.php?title=Taliban&action=edit .
> I tested it on my local wiki, and by setting
>   $wgNavigableTOCCollapseEnable = true;
> in LocalSettings.php I got the button to appear, but it seems broken. When
> clicking it, the NTOC text disappears, but the edit area is not resized. The
> button also disappears, so there is no way to get the text back.
> 
Yes, the collapsing of the NTOC is sort of broken at the moment (was much worse before I took a stab at it); this is a known issue that was probably caused by one of Trevor's restructurings, so either he or Adam should fix it. CCing Trevor for this reason.
Comment 5 Trevor Parscal 2010-01-22 23:27:48 UTC
This has been fixed, a while ago actually. Say, around r53970.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links