Last modified: 2014-11-17 10:36:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T23219, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 21219 - Cannot undo text changes when going back after preview
Cannot undo text changes when going back after preview
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UsabilityInitiative (Other open bugs)
unspecified
All All
: Normal major with 1 vote (vote)
: ---
Assigned To: Trevor Parscal
:
: 24508 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-10-21 08:02 UTC by Thomas Bertels
Modified: 2014-11-17 10:36 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Thomas Bertels 2009-10-21 08:02:59 UTC
We used to be able to undo text changes with the CTRL+Z shortcut (Edit>Undo). This is after clicking the show preview button and going back to the previous page.
This is not possible anymore.

Steps to reproduce :
1. Open an article to edit (by example http://en.wikipedia.org/w/index.php?title=Water_cycle&action=edit)
2. Modify something in the text.
3. Click "Show preview"
4. Go back to the http://en.wikipedia.org/w/index.php?title=Water_cycle&action=edit page (with the browser back button).
5. Try undo the changes from 2. with CTRL+Z or Edit>Undo.

Results :
Cannot undo.

Expected results :
Be able to undo.

Reproduced with Firefox 3.5, Opera 9.63, IE 6 (sic).

Now if I adblock http://en.wikipedia.org/w/extensions/UsabilityInitiative/js/js2.combined.min.js?8 it works again.

Setting the severity to major because it can induce a loss of work.
Comment 1 Thomas Bertels 2009-10-21 08:34:20 UTC
Previously, this bug was only reproduceable when the user choose to try the Acai beta. More precisely, it was linked to the new toolbar (disabling it in the preferences "fixed" the bug).

A quick fix would be to avoid sending the UsabilityInitiative related files to the users who didn't choose to try the beta (as it was the case in the beginning).
Comment 2 Roan Kattouw 2009-10-21 16:23:22 UTC
(In reply to comment #1)
> Previously, this bug was only reproduceable when the user choose to try the
> Acai beta. More precisely, it was linked to the new toolbar (disabling it in
> the preferences "fixed" the bug).
> 
> A quick fix would be to avoid sending the UsabilityInitiative related files to
> the users who didn't choose to try the beta (as it was the case in the
> beginning).
> 

This regression seems to be caused by the ClickTracking extension, I'll look at it later today.
Comment 3 Roan Kattouw 2009-10-21 16:55:45 UTC
(In reply to comment #2)
> This regression seems to be caused by the ClickTracking extension, I'll look at
> it later today.
> 
Fixed this particular regression in r57978 (not live yet).
Comment 4 Trevor Parscal 2010-01-26 00:29:45 UTC
This has clearly been resolved, and is actually no longer relevant given we don't use a textarea at all anymore.
Comment 5 Thomas Bertels 2010-01-26 08:17:26 UTC
I can still reproduce (by enabling the "enhanced editing toolbar" in the Editing preferences), so I guess it isn't live yet?
Comment 6 Roan Kattouw 2010-01-26 13:52:32 UTC
(In reply to comment #4)
> This has clearly been resolved, and is actually no longer relevant given we
> don't use a textarea at all anymore.

That actually doesn't make it irrelevant, because browser support for Ctrl+Z in iframes isn't perfect either. The only thing that really resolves this is the side-by-side preview feature because it allows you to stay on the same page while previewing. Leaving as FIXED because we do have a solution for this in trunk (side-by-side preview).

(In reply to comment #5)
> I can still reproduce (by enabling the "enhanced editing toolbar" in the
> Editing preferences), so I guess it isn't live yet?

No, not yet.
Comment 7 Thomas Bertels 2010-06-10 09:50:29 UTC
Reopening as obviously it isn't fixed, though the changes are live.
Comment 8 Thomas Bertels 2010-10-20 16:05:35 UTC
*** Bug 24508 has been marked as a duplicate of this bug. ***
Comment 9 Thomas Bertels 2011-01-09 22:22:00 UTC
Seems ok Now.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links