Last modified: 2011-05-15 09:54:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T23180, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 21180 - Classical toolbar above on section=new
Classical toolbar above on section=new
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.16.x
All All
: Normal normal (vote)
: ---
Assigned To: Jan Paul Posma
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-10-19 13:15 UTC by Platonides
Modified: 2011-05-15 09:54 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Fix (660 bytes, patch)
2011-04-22 12:59 UTC, Jan Paul Posma 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Platonides 2009-10-19 13:15:06 UTC 
wpSummary has been moved above wpTextbox1 on section=new. When using the classical toolbar, wpSummary is below the toolbar, with a margin to the textarea.
The toolbar should probably be placed below wpSummary, as in acai toolbar.
Comment 1 Brion Vibber 2009-10-19 22:52:29 UTC 
Trevor, was the move a deliberate change or do we just have an inconsistency?
Comment 2 Jan Paul Posma 2011-04-22 12:59:11 UTC 
Created attachment 8442 [details]
Fix

This fixes the problem by moving the toolbar directly above the textarea. There is no reason why the toolbar should be outside of the <form>, right?

Apply patch to trunk/phase3.
Comment 3 Roan Kattouw 2011-04-22 13:35:36 UTC 
(In reply to comment #2)
> Created attachment 8442 [details]
> Fix
> 
> This fixes the problem by moving the toolbar directly above the textarea. There
> is no reason why the toolbar should be outside of the <form>, right?
> 
> Apply patch to trunk/phase3.
Trevor, could you confirm that there are no obscure CSS issues that would be caused by moving the toolbar into the <form> ?
Comment 4 Trevor Parscal 2011-04-22 17:14:44 UTC 
The new toolbar wraps around the textarea, so there's no problems.
Comment 5 Roan Kattouw 2011-04-25 11:37:01 UTC 
(In reply to comment #4)
> The new toolbar wraps around the textarea, so there's no problems.
Of course not, I was being stupid.

Patch committed in r86845.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links