Last modified: 2009-10-14 20:35:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T23115, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 21115 - wgCanonicalSpecialPageName is set wrong on pages named like special pages
wgCanonicalSpecialPageName is set wrong on pages named like special pages
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
http://www.mediawiki.org/wiki/Manual:...
: easy, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2009-10-12 15:58 UTC by Umherirrender
Modified: 2009-10-14 20:35 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Fix leaving wgCanonicalSpecialPageName as false for normal pages (660 bytes, patch)
2009-10-14 20:14 UTC, Platonides 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Umherirrender 2009-10-12 15:58:25 UTC 
The javascript variable wgCanonicalSpecialPageName is set wrong on pages named like special pages.

Look at [[mw:Manual:Watchlist]]: wgCanonicalSpecialPageName="Watchlist", wgTitle="Watchlist"

but we are not an the watchlist ([[mw:Special:Watchlist]]) that breaks js with only look for the canonical name.
Comment 1 Niklas Laxström 2009-10-14 18:00:17 UTC 
Should the variable be always defined and false, or only defined when in ns_special namespace?
Comment 2 Brion Vibber 2009-10-14 18:03:12 UTC 
Hmm, honestly it should be safe to just drop it when not on a special page... undefined var should evaluate as false in boolean checks.

But if we want to be sticklers, we can leave it in as false -- that's current behavior (when not on a page that happens to share a special page name ;)
Comment 3 Platonides 2009-10-14 20:14:02 UTC 
Created attachment 6669 [details]
Fix leaving wgCanonicalSpecialPageName as false for normal pages
Comment 4 Alexandre Emsenhuber [IAlex] 2009-10-14 20:35:58 UTC 
Fixed in r57721.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links