Last modified: 2011-04-30 01:21:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T23099, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 21099 - PHP warning on Saving Page Edit (MySQL result sets not freed)
PHP warning on Saving Page Edit (MySQL result sets not freed)
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.15.x
Other Linux
: Normal trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-10-11 16:31 UTC by Steve
Modified: 2011-04-30 01:21 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Steve 2009-10-11 16:31:41 UTC
With mysql.trace_mode = on set in the php.ini file the following warning is recorded to the php error log when saving a page:

PHP Warning:  Unknown: 2 result set(s) not freed. Use mysql_free_result to free result sets which were requested using mysql_query() in Unknown on line 0
Comment 1 Chad H. 2009-10-22 19:13:08 UTC
I know Tim's mentioned before that we don't need to free results (CCing him), but is this really a problem? mysql.trace_mode is a debugging tool afaik, not something that should be run on live sites. INVALID?
Comment 2 Tim Starling 2009-10-22 23:58:35 UTC
Yeah, my analysis that this warning, and the advice in the PHP manual, both result from a misconception on the part of the author of the mysql module. Testing shows that resources are freed when the reference count of the zval goes to zero, e.g. on unset().

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links