Last modified: 2009-11-04 12:59:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T23089, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 21089 - Upload errors in uploads should not require reuploading
Upload errors in uploads should not require reuploading
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Uploading (Other open bugs)
1.16.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Bryan Tong Minh
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-10-10 19:39 UTC by Bryan Tong Minh
Modified: 2009-11-04 12:59 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bryan Tong Minh 2009-10-10 19:39:23 UTC
Upload errors that can be solved by renaming should not require reuploading. Those are things like illegal names and such. It should only prompt the filename textbox.
Comment 1 Brion Vibber 2009-10-14 18:45:09 UTC
Strongly agreed. :) This should fit in fine with the warning/override infrastructure we've already got, just need to add a UI for changing the target name while we're in there.

[And we could probably benefit from being able to show a thumbnail in this stage, but that may be harder to rig up cleanly...]
Comment 2 Bryan Tong Minh 2009-10-14 19:22:23 UTC
I'm currently working on this.

(In reply to comment #1)
> 
> [And we could probably benefit from being able to show a thumbnail in this
> stage, but that may be harder to rig up cleanly...]
> 
Any idea on how to handle this? And especially once that would also work on Wikimedia?
Comment 3 Michael Dale 2009-10-14 20:43:02 UTC
yea...was something I wanted to get to as well... I have clarified the summary a bit. The ignore errors code works in non-javascript uploads without js2 / upload api. What is presently broken is upload api js2 uploads are not saving data for re-upload on errors and instead resubmitting with ignore errors flagged. 

Furthermore an enhancement could be made to enable "re-naming" inline or "ignoring the error" and uploading from stash via api request. Also would be cool to support a "preview" option should be added that forces a "warring" / upload from stash with inline rendering of expected output.   

Bryan TongMinh are you working on the API side of things? I could setup the js2 upload interface adjustments. 
Comment 4 Michael Dale 2009-10-15 00:15:48 UTC
oky fixed up js2 session state usage in 57732

I think the enhancement to let you rename inline and on the warning page should be a separate bug
Comment 5 Bryan Tong Minh 2009-10-15 08:53:30 UTC
I was more pointing towards regular uploads via the normal upload special page, which I am working on. But it should also be supported on the API/js2 side.
Comment 6 Bryan Tong Minh 2009-11-04 12:59:49 UTC
Fixed in r57868 and subsequent revisions.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links